Refactor tests for cluster health collector #440
+195
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a more robust test for the cluster health collector by abstracting the parsing of a response into a single function. Fixtures have been added for multiple elasticsearch versions to ensure compatibility. This is in preparation for a larger refactoring and will ensure that future changes maintain the desired functionality. Signed-off-by: Joe Adams <github@joeadams.io>
sysadmind
force-pushed
the
update-tests-cluster-health
branch
from
3f0df8e to
f52ecc1
Compare
|
Needs a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a more robust test for the cluster health collector by abstracting the parsing of a response into a single function. Fixtures have been added for multiple elasticsearch versions to ensure compatibility. This is in preparation for a larger refactoring and will ensure that future changes maintain the desired functionality.