Feature/system ha peer #347
Open
+175
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Örnfeldt Philip (66140321) <[email protected]>
Signed-off-by: Örnfeldt Philip (66140321) <[email protected]>
Signed-off-by: Philip Örnfeldt <[email protected]>
Signed-off-by: Örnfeldt Philip (66140321) <[email protected]>
Signed-off-by: Örnfeldt Philip (66140321) <[email protected]>
Signed-off-by: Örnfeldt Philip (66140321) <[email protected]>
Philldomd
force-pushed
the
feature/system-ha-peer
branch
from
2e087a1 to
2e5b08f
Compare
Signed-off-by: Örnfeldt Philip (66140321) <[email protected]>
Philldomd
force-pushed
the
feature/system-ha-peer
branch
from
51c20c8 to
404c0d5
Compare
SuperQ
requested changes
Nov 21, 2025
| * _System/HAChecksums_ | ||
| * `fortigate_ha_member_has_role` | ||
| * _System/HAPeer_ | ||
| * `fortigate_ha_peer` |
Contributor
There was a problem hiding this comment.
This needs to be updated to match the metrics exported.
| @@ -0,0 +1,71 @@ | |||
| // Copyright 2025 The Prometheus Authors | |||
Contributor
There was a problem hiding this comment.
Suggested change
| // Copyright 2025 The Prometheus Authors | |
| // Copyright The Prometheus Authors |
| @@ -0,0 +1,73 @@ | |||
| // Copyright 2025 The Prometheus Authors | |||
Contributor
There was a problem hiding this comment.
Suggested change
| // Copyright 2025 The Prometheus Authors | |
| // Copyright The Prometheus Authors |
| ) | ||
|
|
||
| func probeSystemHaPeer(c http.FortiHTTP, meta *TargetMetadata) ([]prometheus.Metric, bool) { | ||
| Info := prometheus.NewDesc( |
Contributor
There was a problem hiding this comment.
These should be lower case, they're not exported variables.
Suggested change
| Info := prometheus.NewDesc( | |
| info := prometheus.NewDesc( |
| []string{"serial", "vcluster", "hostname", "priority"}, nil, | ||
| ) | ||
|
|
||
| Primary := prometheus.NewDesc( |
Contributor
There was a problem hiding this comment.
Suggested change
| Primary := prometheus.NewDesc( | |
| primary := prometheus.NewDesc( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information Metric for online and standby status of HA Peer