[yum.sh] Explicitly disable "running kernel"-check #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svalouch
force-pushed
the
master
branch
2 times, most recently
from
715568c to
f0cb8c3
Compare
On my OracleLinux 8 and 9 machines, I get unexpected output when a
kernel update has been installed but the node has not yet rebooted to
run the new kernel. The issue is that "autocheck_running_kernel" is
enabled on these machines, and it causes yum/dnf to output things the
script doesn't expect. The setting may not be enabled on other systems,
but it seems like a sane solution to disable it to force a consistent
behaviour regardless of the system-wide settings.
The problem shows itself like this:
# ./yum.sh
# HELP yum_upgrades_pending Yum package pending updates by origin.
# TYPE yum_upgrades_pending gauge
yum_upgrades_pending{origin="is"} 1
yum_upgrades_pending{origin="kernel-core-4.18.0-553.33.1.el8_10.x86_64"} 1
# HELP node_reboot_required Node reboot is required for software updates.
# TYPE node_reboot_required gauge
node_reboot_required 1
This is because the output is as follows (forcing the setting on to make
reproduction easier):
# yum -q --setopt=autocheck_running_kernel=1 check-update
Security: kernel-core-4.18.0-553.34.1.el8_10.x86_64 is an installed security update
Security: kernel-core-4.18.0-553.33.1.el8_10.x86_64 is the currently running version
With this commit applied, the collector script works as desired:
# HELP yum_upgrades_pending Yum package pending updates by origin.
# TYPE yum_upgrades_pending gauge
yum_upgrades_pending{origin=""} 0
# HELP node_reboot_required Node reboot is required for software updates.
# TYPE node_reboot_required gauge
node_reboot_required 1
Tested on OracleLinux 8 and 9.
Signed-off-by: svalouch <[email protected]>
|
Nice analysis. Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my OracleLinux 8 and 9 machines, I get unexpected output when a kernel update has been installed but the node has not yet rebooted to run the new kernel. The issue is that "autocheck_running_kernel" is enabled on these machines, and it causes yum/dnf to output things the script doesn't expect. The setting may not be enabled on other systems, but it seems like a sane solution to disable it to force a consistent behaviour regardless of the system-wide settings.
The problem shows itself like this:
This is because the output is as follows (forcing the setting on to make reproduction easier):
# yum -q --setopt=autocheck_running_kernel=1 check-update Security: kernel-core-4.18.0-553.34.1.el8_10.x86_64 is an installed security update Security: kernel-core-4.18.0-553.33.1.el8_10.x86_64 is the currently running versionWith this commit applied, the collector script works as desired:
Tested on OracleLinux 8 and 9.