Add silence logging option #2536
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: m-masataka <[email protected]>
Signed-off-by: m-masataka <[email protected]>
SuperQ
reviewed
May 4, 2021
| @@ -186,6 +186,7 @@ func run() int { | |||
| dataDir = kingpin.Flag("storage.path", "Base path for data storage.").Default("data/").String() | |||
| retention = kingpin.Flag("data.retention", "How long to keep data for.").Default("120h").Duration() | |||
| alertGCInterval = kingpin.Flag("alerts.gc-interval", "Interval between alert GC.").Default("30m").Duration() | |||
| silenceLogging = kingpin.Flag("silences.logging", "Enable logging silences. If it is enabled, the status change of silence will be logged").Bool() | |||
There was a problem hiding this comment.
This should match the existing log-related flags like --log.level, so how about "log.silences"?
|
Can we have a distinction between the silences gossipped and the ones created in the current instance? |
This was referenced Dec 17, 2024
could you expand on this? like tag them with a string of some sort, or disable logging for one or the other? so far I haven't adressed this in #4163 but if it's the former, that should be fairly simple to do. |
|
i've also fixed conflicts in #4163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Past silences are really important to postmortem our alert management operations.
We need to get "when" and "what kind of" create/edit/delete silences.
So this PR added optional function that logging silence change.