Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): use version.ComponentUserAgent #4150

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Dec 5, 2024

Description

It migrates from github.com/prometheus/common/sigv4 to github.com/prometheus/sigv4 and uses version.ComponentUserAgent("Alertmanager") instead of fmt.Sprintf("Alertmanager/%s", version.Version)

@mmorel-35 mmorel-35 changed the title chore(deps): bump github.com/prometheus/common from 0.60.0 to 0.61.0 and use version.PrometheusUserAgent chore(deps): bump github.com/prometheus/common from 0.60.0 to 0.61.0 and use version.ComponentUserAgent Dec 5, 2024
@mmorel-35 mmorel-35 marked this pull request as draft December 5, 2024 07:31
@mmorel-35 mmorel-35 force-pushed the prometheus/[email protected] branch 2 times, most recently from ff00100 to 193eba7 Compare December 5, 2024 21:48
@mmorel-35 mmorel-35 marked this pull request as ready for review December 5, 2024 22:26
@mmorel-35 mmorel-35 marked this pull request as draft December 6, 2024 19:50
@SuperQ
Copy link
Member

SuperQ commented Jan 15, 2025

Fixed in #4168.

@SuperQ SuperQ closed this Jan 15, 2025
@mmorel-35
Copy link
Contributor Author

@SuperQ ,
Please reopen,
The use of the new method for user agent is not covered in the referenced issue

@SuperQ SuperQ reopened this Jan 15, 2025
@SuperQ
Copy link
Member

SuperQ commented Jan 15, 2025

Sorry, I missed that part.

…0 and use `version.ComponentUserAgent`

Signed-off-by: Matthieu MOREL <[email protected]>
@mmorel-35 mmorel-35 marked this pull request as ready for review January 15, 2025 16:20
@mmorel-35 mmorel-35 changed the title chore(deps): bump github.com/prometheus/common from 0.60.0 to 0.61.0 and use version.ComponentUserAgent chore(deps): use version.ComponentUserAgent Jan 15, 2025
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@SuperQ SuperQ merged commit 6703b0a into prometheus:main Jan 15, 2025
11 checks passed
@mmorel-35 mmorel-35 deleted the prometheus/[email protected] branch January 15, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants