allow specification of query_name by probe param for dns prober #1105
+82
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a useful feature, but it looks like you need to sign the DCO in order to get CI to pass (and to have any chance of it being merged) |
allow specification of query_name by probe param for dns prober Signed-off-by: FOWind <[email protected]>
FOWind
force-pushed
the
feat/spec_query_name
branch
from
d70b56d
to
c4172e4
Compare
|
When merge with the master? This is useful feature! |
|
Are there any updates on this PR? |
|
This is a very useful feature! Any chance it can be reviewed/merged/released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issues: #1104
allow specification of query_name by probe param for dns prober