Fixed target parsing #1137
Open
Fixed target parsing #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved http(s) scheme check so that target may be passed in lower and upper cases. Signed-off-by: Roman Astrakhantsev <[email protected]>
| @@ -309,7 +309,8 @@ func ProbeHTTP(ctx context.Context, target string, module config.Module, registr | |||
|
|
|||
| httpConfig := module.HTTP | |||
|
|
|||
| if !strings.HasPrefix(target, "http://") && !strings.HasPrefix(target, "https://") { | |||
| targetLower := strings.ToLower(target) | |||
| if !strings.HasPrefix(targetLower, "http://") && !strings.HasPrefix(targetLower, "https://") { | |||
There was a problem hiding this comment.
thanks for the PR, can you please add a test so don't break this accidently in the future :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved http(s) scheme check so that target may be passed in lower and upper cases.
Before the fix works only schemes:
After the fix also works schemes alike: