Fix generateCertificate helper function (prober tests) #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santihernandezc
force-pushed
the
santihernandezc/fix_generateCertificate_helper_function
branch
from
bedf86e to
b3bc308
Compare
Signed-off-by: Santiago Hernández <[email protected]> Signed-off-by: Santiago <[email protected]>
Signed-off-by: Santiago <[email protected]>
santihernandezc
force-pushed
the
santihernandezc/fix_generateCertificate_helper_function
branch
from
c512792 to
7bf6db6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All certificated created by
generateCertificate()are self-signed. This PR fixes that by passing the correct argument forparent.