Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle HTTP regexps from params #1247

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

alpadotsh
Copy link

@alpadotsh alpadotsh commented May 27, 2024

This PR implements getting HTTP prober regexp matchers from the query parameters. It's a quick and dirty implementation, looking for comments.

Sample usage:

Config:

modules:
  http_2xx:
    prober: http
    http:
      preferred_ip_protocol: "ip4"
      enable_regexps_from_params: true

Request:

http://localhost:9115/probe?target=https://prometheus.io&module=http_2xx&debug=true&fail_if_body_not_matches_regexp=https://github.com/prometheus

Regexps must be URI encoded.

Alexander Pashkov added 5 commits May 28, 2024 08:39
Signed-off-by: Alexander Pashkov <[email protected]>
Signed-off-by: Alexander Pashkov <[email protected]>
Signed-off-by: Alexander Pashkov <[email protected]>
Signed-off-by: Alexander Pashkov <[email protected]>
Signed-off-by: Alexander Pashkov <[email protected]>
@hatl
Copy link

hatl commented Sep 23, 2024

what is blocking the merge?

@EconomicTouristsArmLate

@hatl Maintainers repeatedly stated they don't want to add dynamic configuration of probe modules (eg #986 (comment)), though it appears to me to be the most requested feature.
Also there is #1277 i guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants