Add fail_if_body_too_large http probe option
#1276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashworks
force-pushed
the
feature/fail_if_body_too_large
branch
from
81b9317
to
1e0ff2b
Compare
hashworks
commented
Aug 6, 2024
| @@ -550,7 +550,7 @@ func ProbeHTTP(ctx context.Context, target string, module config.Module, registr | |||
|
|
|||
| if !requestErrored { | |||
| _, err = io.Copy(io.Discard, byteCounter) | |||
| if err != nil { | |||
| if err != nil && (errors.Is(err, &http.MaxBytesError{}) || httpConfig.GetFailIfBodyTooLarge()) { | |||
There was a problem hiding this comment.
Please check if this is okay or if I should move this to another if so it's clearer.
hashworks
commented
Aug 6, 2024
| @@ -450,6 +451,13 @@ func (s *HeaderMatch) UnmarshalYAML(unmarshal func(interface{}) error) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (h HTTPProbe) GetFailIfBodyTooLarge() bool { | |||
There was a problem hiding this comment.
Alternatively I could do the nil check in UnmarshalYAML, but then it could panic if someone changes the variable under the hood later on.
This can be used in conjunction with `body_size_limit` when it is expected that endpoints return a body larger than the specified limit, e.g. streaming endpoints that potentially return infinite data. Signed-off-by: Justin Kromlinger <[email protected]>
hashworks
force-pushed
the
feature/fail_if_body_too_large
branch
from
1e0ff2b
to
2d225ab
Compare
|
Do you want any changes here? Or is this a feature you don't want merged? |
Signed-off-by: Justin Kromlinger <[email protected]>
hashworks
force-pushed
the
feature/fail_if_body_too_large
branch
from
2a3f154
to
1512b95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used in conjunction with
body_size_limitwhen it is expected that endpoints return a body larger than the specified limit, e.g. streaming endpoints that potentially return infinite data.