Use yaml.v3 to drop yaml.v2 direct dependency #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you rebase, resolve conflicts, and add a meaningful PR description with "what?" and "why?" for this change. |
This update replaces `yaml.v2` with `yaml.v3`. While the change does not directly impact blackbox_exporter functionality, `yaml.v3` provides improved features, better YAML 1.2 compliance, and security enhancements. Upgrading ensures the project stays aligned with best practices and benefits from the latest module improvements. Signed-off-by: Mikel Olasagasti Uranga <[email protected]>
mikelolasagasti
force-pushed
the
yaml.v3
branch
from
1ff6fe7 to
54bb996
Compare
| @@ -30,7 +30,7 @@ import ( | |||
| "github.com/prometheus/client_golang/prometheus/promhttp" | |||
| "github.com/prometheus/common/expfmt" | |||
| "github.com/prometheus/common/promslog" | |||
| "gopkg.in/yaml.v2" | |||
| "gopkg.in/yaml.v3" | |||
There was a problem hiding this comment.
I see @SuperQ's comment about blockers around upgrading to v3. go-yaml/yaml#665 (comment)
so I will hold and wait for @SuperQ's review on this before we merge this.
|
I would love to get this in and get the new features like comments, but looks like this is bit more involved then just updating the dependency. There is a behaviour change, and I am afraid that might break people's config. If and when we do this, we will need to either verify that this is not breaking config for users, and if it's breaking, we will need to give advance notice. also see: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use yaml.v3 to drop yaml.v2 direct dependency.
see https://github.com/go-yaml/yaml#compatibility