Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align kafka connect metrics #635

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ialexivy
Copy link

Currently, the Kafka connect task status is exposed under kafka_connect_connector_status which is not the connector status, and if the connector failed to start nothing gets exposed, I have added the Kafka connect connector metrics and renamed the existing status to kafka_connect_connector_task_status, more details are provided here:
#633
Signed-off-by: alexivsn [email protected]

Copy link

@superfav superfav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +65 to +71
- pattern: 'kafka.(.+)<type=connector-metrics, connector=(.+)><>(connector-class|connector-type|connector-version|status): (.+)'
name: kafka_connect_connector_$3
value: 1
labels:
connector: "$2"
$3: "$4"
help: "Kafka Connect $3 JMX metric type connector"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first group is unused. Can it be removed?

Suggested change
- pattern: 'kafka.(.+)<type=connector-metrics, connector=(.+)><>(connector-class|connector-type|connector-version|status): (.+)'
name: kafka_connect_connector_$3
value: 1
labels:
connector: "$2"
$3: "$4"
help: "Kafka Connect $3 JMX metric type connector"
- pattern: 'kafka.connect<type=connector-metrics, connector=(.+)><>(connector-class|connector-type|connector-version|status): (.+)'
name: kafka_connect_connector_$2
value: 1
labels:
connector: "$1"
$2: "$3"
help: "Kafka Connect $2 JMX metric type connector"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants