Allow comment characters within configuration values when using my.cnf

config/config.go

@@ -52,6 +52,8 @@ var (
 		Loose: true,
 		// MySQL ini file can have boolean keys.
 		AllowBooleanKeys: true,
+		// Allow comment characters inside values.
+		SpaceBeforeInlineComment: true,
 	}
 
 	err error

config/config_test.go

@@ -139,6 +139,28 @@ func TestValidateConfig(t *testing.T) {
 		convey.So(section.User, convey.ShouldEqual, "abc")
 		convey.So(section.Password, convey.ShouldEqual, "")
 	})
+
+	convey.Convey("Comment characters in password", t, func() {
+		c := MySqlConfigHandler{
+			Config: &Config{},
+		}
+		if err := c.ReloadConfig("testdata/comment_char_in_password.cnf", "localhost:3306", "", true, log.NewNopLogger()); err != nil {
+			t.Error(err)
+		}
+		cfg := c.GetConfig()
+		convey.Convey("hash", func() {
+			section := cfg.Sections["client.hash"]
+			convey.So(section.Password, convey.ShouldEqual, "abc#xyz")
+		})
+		convey.Convey("semicolon", func() {
+			section := cfg.Sections["client.semicolon"]
+			convey.So(section.Password, convey.ShouldEqual, "abc;xyz")
+		})
+		convey.Convey("hash and semicolon", func() {
+			section := cfg.Sections["client.both"]
+			convey.So(section.Password, convey.ShouldEqual, "abc#xyz;pqr")
+		})
+	})
 }
 
 func TestFormDSN(t *testing.T) {

config/testdata/comment_char_in_password.cnf

@@ -0,0 +1,9 @@
+[client.hash]
+user = test
+password = abc#xyz
+[client.semicolon]
+user = test
+password = abc;xyz
+[client.both]
+user = test
+password = abc#xyz;pqr