-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node_filesystem_mount_info metric #2970
Conversation
Fixes: prometheus#1384 Signed-off-by: Miguel Oliveira <[email protected]>
Signed-off-by: Miguel Oliveira <[email protected]>
Signed-off-by: Miguel Oliveira <[email protected]>
@SuperQ I think this makes sense. I'm a bit confused why the e2e test doesn't fail due to the new metric though? |
I took a look at the pipeline and I think the output coming from end to end test script is not being used for some comparison. Maybe check metrics script should have been used after end to end test script ran? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Mount info is now fetched from
/proc/1/mountinfo
(falling back to/proc/self/mountinfo
), which contains strictly more information than/proc/1/mounts
. This closes #1384 and introduces a workaround to #885 by letting the user join on major and minor fields.