Build CPUInfo on Darwin #692
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localhots
force-pushed
the
cpuinfo_darwin
branch
from
0e1b617 to
86b04be
Compare
Signed-off-by: Gregory Eremin <[email protected]>
localhots
force-pushed
the
cpuinfo_darwin
branch
from
86b04be to
ef3b3e4
Compare
SuperQ
requested changes
Mar 31, 2025
| @@ -0,0 +1,19 @@ | |||
| // Copyright 2020 The Prometheus Authors | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2020 The Prometheus Authors | |
| // Copyright 2025 The Prometheus Authors |
Comment on lines
-14
to
-15
| //go:build linux | ||
| // +build linux |
There was a problem hiding this comment.
Removing this will likely break other non-linux non-darwin OSs like BSDs, etc.
There was a problem hiding this comment.
I was worried about that too but couldn't find a better solution. Will you be able to suggest better build tags?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpuinfo.gois currently only built on Linux and it breaks Darwin builds for no apparent reason.I understand that there's no procfs on Darwin but it should still be possible to use macOS for development of projects that use this package.
This change allows it to be built on Darwin with a dummy
parseCPUInfoimplementation.Please let me know if I need to change this solution in any way. Thanks!