feat: Add support for custom endpoints and airgap deployment mode #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkerkhove
requested changes
Sep 26, 2025
There was a problem hiding this comment.
As per #188 (review), please do not update and ship a new version
tomkerkhove
reviewed
Sep 26, 2025
| replicaCount: 1 | ||
|
|
||
| # Flag to enable airgap deployment mode | ||
| airgap: false |
There was a problem hiding this comment.
Why do we need an "airgap" flag? This is Microsoft specific and looks to be used only for ca cert path.
Instead, use a certificates.ca.useCustom option that requires certificates.ca.crtPath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been changed
This PR adds support for custom Azure API endpoints and airgap deployment mode for Mariner OS.
Key changes:
Updated chart versions:
Why this is needed
This change enables Promitor agents to be deployed in air-gapped environments with custom Azure API endpoints and proper certificate configuration.
Checklist