Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 compatibility #425

Merged
merged 5 commits into from
Apr 26, 2022
Merged

PHP 8.1 compatibility #425

merged 5 commits into from
Apr 26, 2022

Conversation

gquemener
Copy link

No description provided.

@gquemener gquemener changed the base branch from master to 7.x December 23, 2021 11:53
@coveralls
Copy link

coveralls commented Dec 23, 2021

Coverage Status

Coverage decreased (-0.002%) to 99.068% when pulling fb23b94 on gquemener:php-8-1-compatibility into 25510bf on prooph:7.x.

@gquemener gquemener force-pushed the php-8-1-compatibility branch 9 times, most recently from c03d3ff to fb23b94 Compare December 26, 2021 09:36
@zluiten
Copy link

zluiten commented Feb 8, 2022

@prolic Can you have a look at this please?

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
@gquemener
Copy link
Author

Seems like you exceeded your plan on Travis
Screenshot from 2022-02-25 17-16-15

https://app.travis-ci.com/github/prooph/event-store/requests

Do you want to move to Github Actions?

@prolic
Copy link
Member

prolic commented Feb 25, 2022 via email

@gquemener gquemener force-pushed the php-8-1-compatibility branch 11 times, most recently from d0754b6 to 051ff93 Compare February 26, 2022 16:22
@gquemener gquemener force-pushed the php-8-1-compatibility branch from 044bc7f to 87466c0 Compare February 26, 2022 16:38
@gquemener gquemener changed the title Php 8 1 compatibility PHP 8.1 compatibility Feb 26, 2022
@gquemener
Copy link
Author

Build is passing, and available here: https://github.com/gquemener/event-store/actions/runs/1903613834.

I haven't setup integration with coveralls.io, as I don't have access to secrets.
Here's a documentation about it: https://github.com/marketplace/actions/coveralls-github-action

@gquemener
Copy link
Author

Any blocker here? Build looks good to me (apart from the coveralls.io integration which could be done on a separate PR).

@zluiten
Copy link

zluiten commented Apr 19, 2022

Ping @prolic. Could you have another look please? Thanks!

@prolic prolic merged commit b60fcb7 into prooph:7.x Apr 26, 2022
@gquemener gquemener deleted the php-8-1-compatibility branch April 27, 2022 09:15
polo2ro added a commit to pharmanity/event-store-php that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants