Sdai adapter and substream #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion, buy function
Sdai adapter sdk integration
…n due to a bug in runPoolBehaviour with constant price pools.
…nt_tx(tx, &sdai_address)
…apter-and-substream Sdk implementation/sdai adapter and substream
kayibal
reviewed
Oct 31, 2024
| 90) / | ||
| 100; | ||
| limits[1] = savingsDai.previewDeposit(limits[0]); | ||
| limits[0] = 3 * (10 ** 24); |
There was a problem hiding this comment.
Can you explain this value it seems very arbitrary.
There was a problem hiding this comment.
@kayibal It is the DAI total supply value approx., and we need to use static values due to the incompatibility issue between substreams and external calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.