Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balancer v3 adapter and substream #126

Open
wants to merge 123 commits into
base: main
Choose a base branch
from

Conversation

ignazio-bovo
Copy link
Collaborator

SSIA

domenicodev and others added 30 commits December 5, 2024 09:03
Copy link

gitguardian bot commented Dec 19, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14904727 Triggered Generic High Entropy Secret c27064f evm/test/BalancerV3SwapAdapter.t.sol View secret
14904728 Triggered Generic High Entropy Secret 500b6bc evm/test/BalancerV3SwapAdapter.t.sol View secret
14904729 Triggered Generic High Entropy Secret 727d79e evm/test/BalancerV3SwapAdapter.t.sol View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

substreams/ethereum-balancer-v2/substreams.yaml Outdated Show resolved Hide resolved
substreams/crates/tycho-substreams/src/lib.rs Show resolved Hide resolved
substreams/ethereum-sfrax/integration_test.tycho.yaml Outdated Show resolved Hide resolved
Comment on lines +8 to +9
initialized_accounts:
- "0xbA1333333333a1BA1108E8412f11850A5C319bA9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the vault contract? Could you please add a comment here describing why this is necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment in 302d458

skip_simulation: true
creation_tx: "0x44d82009c125f39bd2bbd1f723e7284e4226d5d752a66b18536e5d92c37b0c82"

- name: test_swap_g_usdc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the adapter supports many cases can we please cover all of them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants