Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template and docs #18

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Update template and docs #18

merged 3 commits into from
Mar 14, 2024

Conversation

kayibal
Copy link
Contributor

@kayibal kayibal commented Mar 14, 2024

No description provided.

kayibal added 3 commits March 14, 2024 12:52
This way the module names are in sync with the gitbook docs.
Remove unecessary pb module, import models from tycho-substreams instead.

Integrate package directly into workspace.
Copy link
Collaborator

@zizou0x zizou0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment

use tycho_substreams::prelude::*;

#[substreams::handlers::map]
fn map_protocol_changes(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to ask for separate files for every handler as we did for others integrations, to make things more readable

Copy link
Collaborator

@louise-poole louise-poole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kayibal kayibal merged commit 4ca484e into main Mar 14, 2024
3 checks passed
@kayibal kayibal deleted the ah/template-and-docs branch March 14, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants