ENG-3406: Add new bytes parameter to swap #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when encoded fee reduction flag is passed we reduce the fee percentage, execute the swap, then revert the fee reduction. TODO: setting the reduced fee percentage needs to be done from the cowswap gpv2 contract
-Move fee reducing logic before calculating the getSellAmount if the order is Buy -Move limit and kind variables inside _executeSwap. Otherwise stack is too deep in swap function -reset adapter allowance before increasing it. Otherwise the allowance risks overflowing. -Use vm.etch to assign the adapter code to the cowswap GPv2 address. This is needed because only the GPv2 contract can modify the swap fee.
compare amount out and gas usage with or without fee reduction
add HardLimits to balancer capabilities
…reduction ENG-3408: Balancer fee reduction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows arbitrary data to be passed.
But it breaks the SDK so it needs to be merged alongside:
This other adapter PR implementing the Balancer fee reduction ENG-3408: Balancer fee reduction #60
DONE ✅ MERGED
This protosim PR (still WIP) https://github.com/propeller-heads/protosim/pull/198
Deploy new protosim version and merge this defibot PR https://github.com/propeller-heads/defibot/pull/3325