Skip to content

fix(execution): allow a missing Infinity pool manager - #1634

Merged
zach030 merged 4 commits into
propeller-heads:mainfrom
aidan46:fix/pancakeswap-infinity-optional-managers
Oct 19, 2026
Merged

fix(execution): allow a missing Infinity pool manager#1634
zach030 merged 4 commits into
propeller-heads:mainfrom
aidan46:fix/pancakeswap-infinity-optional-managers

Conversation

@aidan46

@aidan46 aidan46 commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

PancakeSwap Infinity on Robinhood has no BinPoolManager (deploy config), so PancakeswapInfinityExecutor's constructor blocked deploying there. Either manager may now be zero, at least one must be set. A swap on a pool type without a manager reverts UnknownPoolType.

Adds the Robinhood entry to executor_deployments.json and deploy-executors.js. Robinhood fork tests build the executor from that entry: CL swaps on the live WETH/USDG pool, Bin reverts.

@github-project-automation github-project-automation Bot moved this to Todo in Tycho Oct 16, 2026
@aidan46
aidan46 force-pushed the fix/pancakeswap-infinity-optional-managers branch from c3f5001 to f830a6e Compare October 16, 2026 16:47
@zach030

zach030 commented Oct 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks! Could you also add the deployment changes to executor_deployments.json and deploy-executors.js, and add test cases for Robinhood?

@aidan46

aidan46 commented Oct 17, 2026

Copy link
Copy Markdown
Contributor Author

Thanks! Could you also add the deployment changes to executor_deployments.json and deploy-executors.js, and add test cases for Robinhood?

Done, config updated and Robinhood tests added.

@aidan46
fix(execution): allow a missing Infinity pool manager
28cd906 
Either manager may now be zero, at least one must be set, and a swap on
a pool type without a manager reverts UnknownPoolType instead of calling
address(0).
@aidan46
feat(execution): deploy PancakeSwap Infinity on Robinhood
dd47192 
Robinhood has no BinPoolManager, so the executor deploys with a zero
one. Fork tests build it from the deployment config: CL swaps, Bin
reverts.
@aidan46
aidan46 force-pushed the fix/pancakeswap-infinity-optional-managers branch from b3726a6 to dd47192 Compare October 17, 2026 17:11
@aidan46
aidan46 deployed to integration-tests October 19, 2026 12:07 — with GitHub Actions Active
@aidan46
aidan46 deployed to integration-tests October 19, 2026 12:07 — with GitHub Actions Active
@aidan46
aidan46 deployed to integration-tests October 19, 2026 12:07 — with GitHub Actions Active
@aidan46
aidan46 deployed to integration-tests October 19, 2026 12:07 — with GitHub Actions Active
@aidan46
aidan46 deployed to integration-tests October 19, 2026 12:07 — with GitHub Actions Active
@zach030
zach030 deployed to integration-tests October 19, 2026 12:29 — with GitHub Actions Active
@zach030
zach030 deployed to integration-tests October 19, 2026 12:29 — with GitHub Actions Active
@zach030
zach030 deployed to integration-tests October 19, 2026 13:22 — with GitHub Actions Active
@github-project-automation github-project-automation Bot moved this from Todo to In Progress in Tycho Oct 19, 2026
@zach030
zach030 deployed to integration-tests October 19, 2026 13:25 — with GitHub Actions Active
@zach030
zach030 deployed to integration-tests October 19, 2026 13:41 — with GitHub Actions Active
@zach030
zach030 merged commit b5826a2 into propeller-heads:main Oct 19, 2026
56 of 62 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Tycho Oct 19, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 19, 2026

This branch was successfully deployed

1 active deployment
integration-tests — 71aa0bf7 Deployed Oct 19, 2026 by zach030 via Forge build, fmt, test (protocols/adapter-integration/evm) #3209
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zach030 zach030 zach030 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Tycho
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aidan46 @zach030