Repository navigation
Conversation
The price level stream emits venues under `fallback:{pamm}` by default,
and the fallback encoder requires `user_data` naming a fallback pool,
which the itest never sets, so every price level swap failed to encode.
Run the stream with `without_fallback_router()` so venues execute as
`pricelevelstream:*` on the venue itself. A swap missing its oracle
overrides now hits the venue's freshness guard and counts as a stale
quote, alongside the override miss/unserved counters. `pamm_venue` no
longer reads the `fallback:` family.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PriceLevelStreamBuilderemits every venue underfallback:{pamm}by default (since 7738c60), andFallbackSwap::from_user_datarequiresuser_datanaming a fallback pool. The itest builds swaps throughtycho_test::execution::encoding::create_solution, which never setsuser_data, so every price level swap failed withFallback swaps require user_data naming the fallback protocol(~1,500 WARNs per 15 minutes on Ethereum).tycho_integration_simulation_execution_*_totalstayed empty for everyfallback:*venue.Change
price_level_stream_processor.rs: build the stream with.without_fallback_router(). Venues are served aspricelevelstream:*and execute on the venue itself through thepricelevelstreamexecutor. A swap without its venue's oracle overrides hits the venue's freshness guard (StaleUpdate,FeedStalledfor Metric) and is recorded as a stale quote;price_level_oracle_override_misses/unservedcount those swaps per venue.main.rs:pamm_venuereads only thepricelevelstream:family; therecord_oracle_override_missesdoc no longer describes a fallback-pool fill.CLAUDE.md: describe the direct execution path.Testing
cargo nextest run -p tycho-integration-test: 36 passedcargo clippy -p tycho-integration-test --all-targets --all-features -- -D warnings: clean🤖 Generated with Claude Code