Config : support providing full hex-encoded seeds via PROPTEST_RNG_SEED#558
Open
matthew-russo wants to merge 1 commit intoproptest-rs:mainfrom
Open
Config : support providing full hex-encoded seeds via PROPTEST_RNG_SEED#558matthew-russo wants to merge 1 commit intoproptest-rs:mainfrom
matthew-russo wants to merge 1 commit intoproptest-rs:mainfrom
Conversation
moodmosaic
reviewed
Apr 18, 2025
moodmosaic
left a comment
There was a problem hiding this comment.
@matthew-russo, thank you for working on this (via #556) 🙏 ❤️
Can we avoid requiring the hex- prefix for replay? The process is already
a bit complex. If the replay file is there, just use it. If not, the failure
message should mention how to replay with hex-. Also, there's
PROPTEST_RNG_SEED to consider. Adding another format rule adds friction.
Better: auto-detect the seed format.
Try to parse the seed as a hex string of the right length.
If that works, use it as a hex seed.
Otherwise, parse it as a u64.
This lets users copy-paste seeds from failure output as-is.
Also works cleanly with PROPTEST_RNG_SEED.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #556