Draft
Conversation
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an argument to the attribute macro
proptest_path = "some::path::to::proptest", which changes where the macro assumes it can find the proptest crate. I.e., if you provideproptest_path = "some::path::to::proptest, the macro will emit:Motivation
At Zed, we have a custom test macro that injects some special arguments, and provides a limited form of property testing. I am improving this macro by using proptest instead of uniformly sampling from a distribution, but the current macro assumes that
::proptestwill always be accessible. Adding this parameter allows thegpui::testmacro to expand to#[gpui::proptest::property_test(proptest_path = "gpui::proptest") fn ..., which removes the need to addproptestas a dependency in every crate that wants to write a test.