Revert "Use file-truename in denote-filename-is-note-p and denote--di…

[jeanphilippegg]

I am reverting commit 5fade0c because it will break Denote for some users.

If one's denote-directory contains symlink subdirectories (that link to
directories outside denote-directory), then some Denote features for those
notes will not work anymore.

We should not use file-truename because those directories will become
"outside" denote-directory. I don't see a non-costly way of doing this
validation. So I just recommend this warning in the manual:

If your `denote-directory` or its subdirectories involve symbolic links, make
sure that you access them using those links (and that
`find-file-visit-truename` is nil). Otherwise, Denote features will not work.

For the same reason, we should remove file-truename to fix related issue
#346 (with the same warning as above). I will do a separate pull request.

[protesilaos]

Merged, thank you!

I don't see a non-costly way of doing this validation.

Perhaps we can provide this as an opt-in feature. Though this also comes down to the complexity of a user's setup, so maybe we should not do anything to account for it.

[protesilaos]

I will do a separate pull request.

Thank you!

[jeanphilippegg]

Perhaps we can provide this as an opt-in feature. Though this also comes down to the complexity of a user's setup, so maybe we should not do anything to account for it.

Yes, it could be a good solution.