chore: ruff-format the source + drop stale STUB/TODO docstrings#5
Merged
Conversation
Normalize every source file with `ruff format` (the test suite + CI already enforced this on tests/; now the whole repo is clean) and broaden the CI format-check back to the whole repo. Pure whitespace — no behaviour change; the 61 tests stay green. Also correct docstrings/comments that described unfinished work that has since landed: - api.py: drop the "webhook HMAC is a TODO" STUB note (HMAC verification is implemented) and the "Poll is the fallback" line (there is no poll — the merge webhook is the only Done edge); fix the /ci comment that pointed at the removed TODO. - loop.py: drop the "STUBBED for review / open_pr is sketched" note (open_pr is fully implemented); keep the accurate concurrency-cap note. - board_view.py: "deferred-until-now UI" -> "the Kanban/list board UI". Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #5 | chore: ruff-format the source + drop stale STUB/TODO docstrings
VERDICT: WARN (CI non-terminal — test: queued)
CI Status
test: queued ⏳
Diff Review
.github/workflows/ci.yml: expandsruff format --checkfromtests/to.— intentional, the source is now formatted (13 files already pass per PR body). No behavioral change.__init__.py,api.py,loop.py,board_view.py:ruff formatpass — pure whitespace/line-break reflow. No logic altered.api.pydocstring: stale STUB note about HMAC being TODO replaced with accurate description of existing_webhook_prHMAC verification. Correct.api.py/cicomment: stale TODO reference removed. Clean.
Observations
- LOW: clawpatch structural review unavailable — repo not in project registry. Proceeding on diff review alone; this PR is formatting-only so structural depth wouldn't add signal.
- No blocking findings. Docstring removals are accurate and well-scoped. Formatting is
ruff-consistent. Awaiting terminal CI for formal PASS.
— Quinn, QA Engineer
|
Submitted COMMENT review on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The cleanup follow-up to the test-suite PR (#4).
ruff formatthe whole source. The suite's CI already format-checkedtests/; this normalizes the source too (it predated a format pass) and broadens the CI step back toruff format --check .. Pure whitespace — no behaviour change; the 61 tests stay green.Drop stale STUB/TODO docstrings that described work which has since landed:
api.py: remove the "webhook HMAC is a TODO" STUB note (HMAC verification is implemented in_webhook_pr) and the "Poll is the fallback" line (there is no poll — the merge webhook is the only Done edge); fix the/cicomment that pointed at the now-removed TODO.loop.py: remove the "STUBBED for review /open_pris sketched" note (open_pris fully implemented inworktree.py); keep the accurate concurrency-cap note.board_view.py: "deferred-until-now UI" → "the Kanban/list board UI".Verification
ruff check .— cleanruff format --check .— 13 files already formattedpytest -q— 61 passed🤖 Generated with Claude Code