feat(board-view): section the console list by state in collapsible groups (v0.22.0)#54
Merged
Merged
Conversation
…oups (v0.22.0) The console Board view's list projection rendered every feature as one flat table. Group it by board state into collapsible sections — COLS order (backlog → ready → in_progress → in_review → done) + a blocked group + a cancelled group (the #47 terminal edge) — mirroring the Kanban's column grouping so a dense board stays scannable. Each section header shows the state name + a count; clicking it collapses the group (header stays, rows omitted). Empty states are omitted. Collapse state lives in a module-scoped Set so the 10s auto-reload re-render doesn't re-expand what the user closed. Token-driven styling (--pl-*), consistent with the existing board CSS. Kanban view untouched — this is the list projection only. Verified: node syntax-check of the module script, and a simulation of the grouping algorithm (COLS order, empty-section omission, counts, collapse, unknown-state-last, empty-board fallback). Contract-tested against the page string (no JS runtime in CI). Closes #26 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
There was a problem hiding this comment.
QA Audit — PR #54 | feat(board-view): section the console list by state in collapsible groups (v0.22.0)
VERDICT: WARN (CI pending — test in_progress; re-review will confirm terminal pass)
CI Status
- test: ⏳ in_progress
Diff Review
- ~70 lines across 4 files: view logic in
board_view.py, version bumps, +3 contract tests - List view now groups rows under collapsible per-state headers in COLS order + blocked + cancelled (#26)
- Module-scoped
COLLAPSEDSet preserves collapse state across 10s auto-reloads - CSS is token-driven (
--pl-*), scoped to#list— Kanban untouched window.toggleGroupexposure follows existingwindow.setViewpattern
Observations
- LOW: clawpatch unavailable (repo not in project registry) — structural review skipped; diff is self-contained (~70 lines, single-view change) so risk is minimal
- Contract tests (
test_board_view.py) assert string-level structure — appropriate given no JS runtime in CI; coverage of LIST_SECTIONS, toggleGroup, COLLAPSED, omit-empty, and Kanban-unchanged is sufficient
— Quinn, QA Engineer
|
Submitted COMMENT review on #54. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idea (#26)
The console Board view's list projection rendered every feature as one flat table. Group it by board state into collapsible sections so a dense board is scannable — mirroring the Kanban's column grouping.
What
backlog → ready → in_progress → in_review → done) + ablockedgroup + acancelledgroup (the Add a way to cancel/delete a feature created in error (no DELETE route, no store method) #47 terminal edge) — so every state a feature can be in has a home in the list.Set), so a re-render doesn't re-expand what the user closed.--pl-*), consistent with the existing board CSS.Kanban view untouched — this is the list projection only.
Verification
No JS runtime in CI, so (like
test_apiguarding the served path) the newtest_board_view.pyasserts the page's structural contract. Beyond that, locally:node --checkof the extracted module script → syntax OK.ruff check+ruff format --checkclean.Acceptance sketch
--pl-*); Kanban left as-isCloses #26
🤖 Generated with Claude Code