fix(onboard): ignore proto session scratch, keep .proto/evolve skills (#49)#57
Merged
Merged
Conversation
…ills (#49) The hygiene step said to gitignore the coder's scratch dir as `.proto/` wholesale — but protoCLI manages skills under `.proto/evolve/`, which should be versioned. Narrow the guidance to the per-session artifacts (.proto/memory/, .proto/session-notes.md, .proto/repo-map-cache.json) and call out the evolve exception. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #57 | fix(onboard): ignore proto session scratch, keep .proto/evolve skills (#49)
VERDICT: WARN (CI pending — test queued)
CI Status
- test: queued
Diff Review
- Adds a single new skill file:
skills/onboard-project/SKILL.md(+94 lines). The skill orchestrates repo readiness — scanning for gaps, delegating safe fixes (beads init, gitignore), and boarding judgment items (grounding doc, PR CI). - The
.gitignorehygiene is now precise: ignores per-session scratch (.proto/memory/,.proto/session-notes.md,.proto/repo-map-cache.json) while explicitly preserving.proto/evolve/— a real fix for the blanket.proto/ignore that would swallow versioned skills.
Observations
- No defects, no unresolved threads, no security concerns. The skill definition is well-structured and the gitignore nuance is correctly encoded.
- ⏳ Non-blocking: CI (
test) is still running. The content itself is clean — re-dispatch on terminal-green for formal PASS.
— Quinn, QA Engineer
|
Submitted COMMENT review on #57. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
onboard-projecthygiene step said to gitignore the coder's scratch as.proto/wholesale — but protoCLI manages skills under.proto/evolve/, which should be versioned. Narrowed to the per-session artifacts (.proto/memory/,.proto/session-notes.md,.proto/repo-map-cache.json) with the evolve exception called out. Mirrors portfolio v0.7.3's_ensure_proto_gitignore.🤖 Generated with Claude Code