feat: Deterministic Persona Drift Detection (#1986) - V2

[mabry1985]

Summary

Deterministic Persona Drift Detection (#1986) - V2 (bd-lsv)

See the diff for details.

[coderabbitai]

Warning

Review limit reached

@mabry1985, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8d3b55a6-03fe-4ef3-b68b-81ab4cd47706

📥 Commits

Reviewing files that changed from the base of the PR and between 0968a42 and 9436eab.

📒 Files selected for processing (4)

• graph/config.py
• graph/config_io.py
• server/agent_init.py
• tests/test_config_roundtrip.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/bd-lsv

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[protoreview]

QA panel review — WARN

code-review-structural · head 9436eabd90b1 · formal

[review-synthesizer completed: workflow code-review-structural:report]

The overall risk of this change is low, as it primarily affects configuration parsing for specific soul-drift parameters. The primary item to fix is the logic in graph/config.py where the or 0 pattern inadvertently overrides class-level defaults when a value of 0 is explicitly provided. The verification pass confirmed this correctness issue; no other findings were raised or refuted. No structural gaps were identified.

[
  {
    "file": "graph/config.py",
    "line": 1103,
    "severity": "minor",
    "category": "correctness",
    "claim": "The use of `or 0` (or `or 0.0`) when parsing `soul_drift_interval_hours` and `soul_drift_threshold` may cause the code to ignore class-level defaults if the value in the config file is explicitly set to 0 or 0.0.",
    "evidence": "soul_drift_interval_hours=int(soul_drift.get(\"interval_hours\", cls.soul_drift_interval_hours) or 0),\nsoul_drift_threshold=float(soul_drift.get(\"threshold\", cls.soul_drift_threshold) or 0.0)",
    "verdict": "confirmed",
    "note": "Confirmed in diff: `soul_drift.get(\"interval_hours\", cls.soul_drift_interval_hours) or 0` will evaluate to `0` if the config value is `0`, `None`, or `False`, effectively ignoring the `cls` default in those cases."
  }
]

[protoreview]

Promoting the WARN verdict for head 9436eabd90b1: all checks terminal-green, zero unresolved review threads. (approve-on-green)