feat(console): Fleet Room — a ⌘K morph-view for the fleet

[mabry1985]

What

Turn the fleet from a page-load switcher into a co-present room summoned from ⌘K — the first piece of the command-palette UX overhaul, and a console-native take on Block/Buzz's "workspace = members-in-a-room" idea (adapted onto our A2A + fleet-proxy substrate — no Nostr, no new infra).

⌘K → Fleet Room (Agents group) morphs the palette into a native view — a sibling of PaletteChat — showing every workspace agent as a presence-aware member:

• Roster + presence — dots encode running / stopped / remote / unreachable / this-instance, with bundle · :port meta. Straight from api.fleet().
• Address in place — click a member, type, ↵ → a slug-targeted send to that member's /api/chat through the hub proxy. No navigation, no leaving the room.
• Broadcast — ⌘↵ (or the target chip) fans the message out to every online member.
• Open / Start / Stop — per-row, reusing the existing fleet wires.

Why core + default

The fleet was already a first-party palette citizen (quick-chat #1733, toggle #1769) and PaletteChat is the exact precedent for a native morph-view — so this is a small extension of existing code in usePaletteRegistry, not a plugin. Ungated, on by default.

How

• FleetRoom.tsx — the native PaletteView; styled entirely through DS tokens (--pl-color-*) so it tracks the console theme in light + dark, no hand-picked colors.
• api.sendToAgent(slug, msg) — non-streaming /api/chat through /agents/<slug>/…; works in the browser and the desktop WKWebView shell alike (no SSE body to read). Broadcast is a fire-and-forget fan-out.
• usePaletteRegistry — registers the view + a "Fleet Room" command at the top of the Agents group; opening a member routes through the palette nav chokepoint, so it forwards correctly from the frameless desktop launcher too.

Scope

Additive — the existing quick-chat/toggle palette entries are untouched; folding them into the room is the natural next step of the overhaul. Deferred to v1 (additive layers on this shell): the live fleet-wide activity feed (aggregate each member's event bus, ADR 0039) + inline reply transcripts.

Testing

• tsc --noEmit, vitest unit, vite build (incl. the css-comment prebuild) — all clean.
• e2e: new ⌘K → Fleet Room lists members with presence and addresses one; full fleet.spec.ts (12) + keybindings.spec.ts (7) green.

Draft — this is a UX call

Leaving as draft, no auto-merge: the "feel" is the reviewable part, and CI can't judge it. The shipped view uses real DS tokens so it's closer to the console than the earlier standalone concept mockup (kept for reference: https://claude.ai/code/artifact/ed0bb3df-35ee-4337-a676-83449e1df8c4).

🤖 Generated with Claude Code

https://claude.ai/code/session_01LyQuxgkFpMUJAQbVXnqz2d

Summary by CodeRabbit

• New Features

  • Added a Fleet Room accessible from the command palette.
  • View fleet members, presence status, and live fleet activity in one place.
  • Open direct chats with individual members, with separate conversation history.
  • Broadcast messages to all online members and receive delivery feedback.
  • Added controls for starting or stopping supported local members.
  • Added live activity updates, including member status changes and ongoing work.

• Tests

  • Expanded end-to-end coverage for Fleet Room navigation, chat, broadcasting, roster presence, and activity feeds.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 36ff0f9e-cbd5-4c85-92d7-4dc853f6532b

📥 Commits

Reviewing files that changed from the base of the PR and between bfae50d and 24e7242.

📒 Files selected for processing (10)

• apps/web/e2e/fleet.spec.ts
• apps/web/e2e/mock-server.mjs
• apps/web/src/app/FleetActivity.tsx
• apps/web/src/app/FleetRoom.tsx
• apps/web/src/app/PaletteChat.tsx
• apps/web/src/app/fleet-activity.css
• apps/web/src/app/fleet-room.css
• apps/web/src/app/paletteChatStore.ts
• apps/web/src/app/usePaletteRegistry.ts
• apps/web/src/lib/api.ts

---

Walkthrough

The PR adds a Fleet Room command-palette view with a sorted member roster, member DMs, start/stop controls, broadcast messaging, and a live activity feed. It adds member-scoped API routing and transcript persistence, plus Playwright coverage and mock chat handling.

Changes

Fleet Room

Layer / File(s)	Summary
Member communication APIs apps/web/src/lib/api.ts, apps/web/e2e/mock-server.mjs	Adds member URL and SSE-token helpers, fire-and-forget broadcasts, member-scoped streaming chat, and a non-streaming mock chat response.
Scoped member chat persistence apps/web/src/app/paletteChatStore.ts, apps/web/src/app/PaletteChat.tsx	Namespaces persisted transcripts by member, changes DM clearing behavior, routes DM streams to the selected member, and adds the member DM palette view.
Live fleet activity feed apps/web/src/app/FleetActivity.tsx, apps/web/src/app/fleet-activity.css	Tracks roster transitions and member SSE events, deduplicates and maps feed events, stores up to 60 items, and renders the activity column.
Fleet Room UI and palette wiring apps/web/src/app/FleetRoom.tsx, apps/web/src/app/fleet-room.css, apps/web/src/app/usePaletteRegistry.ts, apps/web/e2e/fleet.spec.ts	Adds the roster, presence states, controls, broadcast composer, styling, command registration, navigation wiring, and end-to-end tests.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant Palette
  participant FleetRoom
  participant FleetAPI
  participant FleetMember
  participant ActivityFeed

  User->>Palette: Select Fleet Room
  Palette->>FleetRoom: Open fleet-room view
  FleetRoom->>FleetAPI: Fetch fleet state
  FleetAPI-->>FleetRoom: Return roster
  FleetRoom->>ActivityFeed: Start activity tracking
  ActivityFeed->>FleetMember: Open SSE stream
  User->>FleetRoom: Broadcast message
  FleetRoom->>FleetAPI: Send message to online members
  FleetAPI->>FleetMember: POST SendStreamingMessage
  FleetRoom->>ActivityFeed: Push broadcast event

Loading

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/fleet-room-cmdk

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[protoreview]

QA panel review — FAIL

code-review-structural · head 24e7242c0ec8 · formal

[review-synthesizer completed: workflow code-review-structural:report]

Prose Brief

This PR carries moderate risk due to the SSE error-recovery gap in FleetActivity.tsx: a transient stream error on a running agent kills the EventSource permanently — the onerror handler explicitly closes the connection and the useEffect won't re-fire until the roster's running-agent set changes, which could be indefinitely. Fix that first. The three minor hygiene findings (a duplicated helper, two unreferenced CSS rules) are cost-free to land alongside but shouldn't gate the PR. The panel was unanimous — all findings confirmed, none refuted. No gaps from the structural pass surfaced findings beyond the panel's. Coverage looks complete: all touched files were read and assessed.

[
  {
    "file": "apps/web/src/app/FleetActivity.tsx",
    "line": 167,
    "severity": "major",
    "category": "correctness",
    "claim": "SSE streams dropped on error are never reopened: the onerror handler deletes the stream from the ref map and calls es.close() (preventing browser auto-reconnect), but the useEffect depends only on sig (a stable sorted-set string of running agent slugs), so it does not re-fire on routine roster polls — the stream stays dead until the roster composition actually changes.",
    "evidence": "useEffect(…, [sig]) at line 174 depends on the derived `sig` string (lines 130-133), not on `data`; es.onerror at lines 165-167 deletes from `streams.current` and calls `es.close()`. The comment on line 167 says 'the next roster poll reopens' but only a sig-changing poll triggers the effect.",
    "verdict": "confirmed",
    "note": "sig is derived from running-agent slugs; react-query structural sharing means data ref is stable across equal polls, so sig stays identical — the effect won't re-fire after a stream error unless a member goes on/offline or is added/removed. The error handler's es.close() also defeats EventSource auto-reconnect. Genuine gap.",
    "source": "correctness"
  },
  {
    "file": "apps/web/src/app/FleetRoom.tsx",
    "line": 29,
    "severity": "minor",
    "category": "conventions",
    "claim": "The `slugOf` helper is duplicated identically between FleetRoom.tsx and FleetActivity.tsx; FleetRoom already imports from FleetActivity and should reuse the existing definition.",
    "evidence": "FleetRoom.tsx line 29: `const slugOf = (a: FleetAgent): string => (a.host ? \"host\" : a.id);` — identical to FleetActivity.tsx line 54. FleetRoom already imports `{ FleetActivityFeed, pushFleetEvent }` from `./FleetActivity`.",
    "verdict": "confirmed",
    "note": "Both files define identical `const slugOf = (a: FleetAgent): string => (a.host ? \"host\" : a.id);`. FleetRoom already imports from './FleetActivity' — adding `slugOf` to that import would deduplicate cleanly.",
    "source": "conventions"
  },
  {
    "file": "apps/web/src/app/fleet-room.css",
    "line": 81,
    "severity": "minor",
    "category": "conventions",
    "claim": "Dead CSS: `.flr__member.is-target` is defined but never applied to any element in FleetRoom.tsx.",
    "evidence": "fleet-room.css lines 81-84 define `.flr__member.is-target { background: color-mix(...); border-color: color-mix(...); }`. FleetRoom.tsx only sets `is-down` dynamically: `className={`flr__member${a.running ? \"\" : \" is-down\"}`}` — `is-target` is never set.",
    "verdict": "confirmed",
    "note": "The only dynamic class on `.flr__member` in FleetRoom.tsx is `is-down`. No code in any changed TSX file sets `is-target` on a `.flr__member` element.",
    "source": "conventions"
  },
  {
    "file": "apps/web/src/app/fleet-room.css",
    "line": 226,
    "severity": "minor",
    "category": "conventions",
    "claim": "Dead CSS: `.flr__target-x` is defined but never referenced in any TSX file.",
    "evidence": "fleet-room.css lines 226-229 define `.flr__target-x { opacity: 0.55; font-weight: 700; }`. A search of all changed TSX files finds no usage of `flr__target-x` or `target-x`.",
    "verdict": "confirmed",
    "note": "`target-x` appears only in the CSS definition. The semantically close class `.flr__target` IS used (the broadcast badge), but `.flr__target-x` is a separate, unreferenced rule — likely a vestige of a planned close/dismiss button.",
    "source": "conventions"
  }
]