This repository was archived by the owner on Jul 20, 2026. It is now read-only.
forked from bioshazard/workstacean
-
Notifications
You must be signed in to change notification settings - Fork 0
promote: v0.7.13 — Quinn e2e fixes + triage pipeline polish #367
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e913ecf
chore: back-merge main → dev (post ee1828ae025ff7c2e1d2892385658d1865…
github-actions[bot] 0b4d8ab
Merge pull request #363 from protoLabsAI/chore/backmerge-main-1776306826
mabry1985 1686d13
fix: webhook dedup, suppress skill-response echo, populate blast-v1 r…
mabry1985 a6a8a26
fix: streaming early-break + push-callback URL routing (#365)
mabry1985 c1dfbc7
chore(release): bump to v0.7.13 (#366)
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -152,6 +152,11 @@ export class A2AExecutor implements IExecutor { | |
| return this.config.name; | ||
| } | ||
|
|
||
| /** Expose the configured agent URL so the dispatcher can pick an appropriate callback base URL. */ | ||
| get url(): string { | ||
| return this.config.url; | ||
| } | ||
|
|
||
| /** | ||
| * Update the streaming + pushNotifications capability flags from the agent | ||
| * card. Called by SkillBrokerPlugin after every card discovery pass so the | ||
|
|
@@ -458,6 +463,16 @@ export class A2AExecutor implements IExecutor { | |
| const delta = this._worldStateDeltaFromParts(artifact.parts); | ||
| if (delta) streamDeltaData[WORLDSTATE_DELTA_MIME_TYPE] = delta; | ||
| } | ||
| // Non-terminal state (submitted / working / input-required) on the | ||
| // initial task event → stop consuming the SSE stream and let | ||
| // TaskTracker drive the task to completion via tasks/get polling. | ||
| // Holding the stream open longer forces slow agents to keep their | ||
| // SSE generator alive for minutes, which crashes them when the | ||
| // sync caller eventually times out and closes the connection. | ||
| if (taskState !== "completed" && taskState !== "failed" | ||
| && taskState !== "canceled" && taskState !== "rejected") { | ||
| break; | ||
| } | ||
|
Comment on lines
+466
to
+475
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Non-terminal early break can drop At Line [466]-[475], the stream now breaks on all non-terminal task states. But the dispatcher currently tracks only Suggested alignment fix (dispatcher side)-const WORKING_STATES = new Set(["submitted", "working"]);
+const NON_TERMINAL_STATES = new Set(["submitted", "working", "input-required"]);
...
- && WORKING_STATES.has(taskState)
+ && NON_TERMINAL_STATES.has(taskState)🤖 Prompt for AI Agents |
||
| continue; | ||
| } | ||
| if (event.kind === "status-update") { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regex won't match agent names containing hyphens.
The pattern
\w+only matches[a-zA-Z0-9_]. Ifthis.config.namecontains a hyphen (e.g.,"proto-agent"), the regex fails and the "echo" comment is posted anyway.🐛 Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents