fix(register): st_register honors configured faction, not hardcoded COSMIC (v2.9.4)

[mabry1985]

Closes #57.

The bug that lost the wipe

st_register defaulted faction="COSMIC" (a literal). At the 2026-07-12 wipe we had pre-configured DOMINION to escape COSMIC's crowded home system. Recovery raced:

• _recover → recover_from_reset registered PROTOTRADER@DOMINION correctly (it uses faction()).
• The agent's own auto-st_register (the 4113 error message prompts "re-register", no faction passed) minted PROTOTRADER-98@COSMIC — the tool default — and its token overwrote the DOMINION one.

The faction was doomed either way: the agent's path never honored the config. We landed in COSMIC, whose new system saturated within ~35 min — the exact dead-end the switch was meant to avoid.

Fix

st_register's faction now defaults to the configured faction() (then COSMIC as the ultimate fallback for brand-new users). Every registration path — agent tool call and supervisor recovery — honors the operator's Starting Faction, so the race is harmless (both register the same faction).

One line where it mattered:

-async def st_register(symbol: str, faction: str = "COSMIC", ...):
+async def st_register(symbol: str, faction: str = "", ...):
+    faction = (faction or "").strip() or _config_faction()

Tests

test_register_faction.py (3): omitted faction → configured DOMINION; explicit faction overrides; unconfigured → COSMIC fallback preserved. Full suite 342 green, ruff clean.

Follow-ups (in #57)

Cosmetic now that faction is correct: the double-register still mints a suffixed call sign (both paths register) — an idempotency guard (skip re-register when the current token is already valid) would keep the clean call sign. Separately: call-sign-persist (set_call_sign is in-process only).

🤖 Generated with Claude Code

[protoquinn]

👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow.

[protoquinn]

QA Audit — PR #58 | fix(register): st_register honors configured faction, not hardcoded COSMIC (v2.9.4)

VERDICT: PASS

---

CI Status

• test: in_progress ⏳

Diff Review

• tools.py: st_register faction default changed from "COSMIC" → "", resolved via _config_faction() with COSMIC ultimate fallback — correct logic
• test_register_faction.py: 3 tests cover all paths (configured → DOMINION, explicit override, unconfigured → COSMIC)
• protoagent.plugin.yaml: version bump 2.9.3 → 2.9.4

Observations

• LOW: CI still settling — approve-on-green policy promotes this to APPROVED once terminal-green

— Quinn, QA Engineer

[protoquinn]

Submitted COMMENT review on #58.

[protoquinn]

✅ CI went terminal-green with no blockers on the prior review — promoting it to APPROVED per the approve-on-green policy (#748).

[protoquinn]

CI terminal-green, no blockers on prior review — auto-approving on green (#748).