Skip to content

Commit

Permalink
Auto-generate files after cl/702072912
Browse files Browse the repository at this point in the history
  • Loading branch information
protobuf-team-bot committed Dec 2, 2024
1 parent a79fbc9 commit f59676d
Show file tree
Hide file tree
Showing 5 changed files with 1,520 additions and 1,456 deletions.
22 changes: 15 additions & 7 deletions php/ext/google/protobuf/php-upb.c
Original file line number Diff line number Diff line change
Expand Up @@ -3998,8 +3998,13 @@ bool upb_Message_DeleteUnknown(upb_Message* msg, upb_StringView* data,
}

size_t upb_Message_ExtensionCount(const upb_Message* msg) {
size_t count;
UPB_PRIVATE(_upb_Message_Getexts)(msg, &count);
const upb_MiniTableExtension* e;
upb_MessageValue val;
size_t iter = kUpb_Message_ExtensionBegin;
size_t count = 0;
while (upb_Message_NextExtension(msg, &e, &val, &iter)) {
count++;
}
return count;
}

Expand Down Expand Up @@ -4179,20 +4184,18 @@ static bool _upb_Message_ExtensionsAreEqual(const upb_Message* msg1,
const upb_Message* msg2,
const upb_MiniTable* m,
int options) {
// Must have identical extension counts.
if (upb_Message_ExtensionCount(msg1) != upb_Message_ExtensionCount(msg2)) {
return false;
}

const upb_MiniTableExtension* e;
upb_MessageValue val1;

// Iterate over all extensions for msg1, and search msg2 for each extension.
size_t count1 = 0;
size_t iter1 = kUpb_Message_ExtensionBegin;
while (upb_Message_NextExtension(msg1, &e, &val1, &iter1)) {
const upb_Extension* ext2 = UPB_PRIVATE(_upb_Message_Getext)(msg2, e);
if (!ext2) return false;

count1++;

const upb_MessageValue val2 = ext2->data;
const upb_MiniTableField* f = &e->UPB_PRIVATE(field);
const upb_MiniTable* subm = upb_MiniTableField_IsSubMessage(f)
Expand All @@ -4216,6 +4219,11 @@ static bool _upb_Message_ExtensionsAreEqual(const upb_Message* msg1,
}
if (!eq) return false;
}

// Must have identical extension counts (this catches the case where msg2
// has extensions that msg1 doesn't).
if (count1 != upb_Message_ExtensionCount(msg2)) return false;

return true;
}

Expand Down
Loading

0 comments on commit f59676d

Please sign in to comment.