C++: wrap generated DescriptorTable variable in extern "C" block #19258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_696239471
branch
2 times, most recently
from
2cc23b7 to
d86e58b
Compare
copybara-service
bot
force-pushed
the
test_696239471
branch
from
d86e58b to
37b10b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++: wrap generated DescriptorTable variable in extern "C" block
To implement extensions in Rust, we are going to need a symbol we can depend on
to force-link the C++ extension registration code. The
descriptor_table_xxxxxvariable seems ideal for this: it already exists and is not public-facing, so
we can reuse it without increasing code size. This CL marks it
extern "C"toensure that we can safely access it from Rust.