Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toolchain type for remaining actions #19262

Closed
wants to merge 1 commit into from

Conversation

kotlaja
Copy link
Contributor

@kotlaja kotlaja commented Nov 14, 2024

This is the first step for migrating to Automatic Exec Groups (check #19261).

I tried migrating with bazel build ... --incompatible_auto_exec_groups, fixed two actions added in this PR, and was stopped by the error:

ERROR: /usr/local/google/home/kotlaja/.cache/bazel/_bazel_kotlaja/3b1d6911411754876f642abf5e6636f0/external/rules_kotlin/kotlin/compiler/BUILD.bazel:22:22: in kt_js_import rule @@rules_kotlin//kotlin/compiler:kotlin-stdlib-js: 
Traceback (most recent call last):
	File "/usr/local/google/home/kotlaja/.cache/bazel/_bazel_kotlaja/3b1d6911411754876f642abf5e6636f0/external/rules_kotlin/kotlin/internal/js/impl.bzl", line 137, column 20, in kt_js_import_impl
		ctx.actions.run(
Error in run: Couldn't identify if tools are from implicit dependencies or a toolchain. Please set the toolchain parameter. If you're not using a toolchain, set it to 'None'.

Still, I think this error will be fixed with upgrading to rules_kotlin 2.0.0.

@kotlaja
Copy link
Contributor Author

kotlaja commented Nov 18, 2024

Closing this PR since these changes will be managed internally and then exported to github.

@kotlaja kotlaja closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant