Refactor how inline string fields are tracked for donation. #24605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_770243667
branch
4 times, most recently
from
8a147ee to
ca7c802
Compare
Instead of a separate HasBits object with one bit per field we track donation in one arbitrary bit in the capacity. When the string IsLong that bit in the capacity determines if it is donated. We also remove all the plumbing for these donation bits, on demand arena destructor, etc. PiperOrigin-RevId: 770243667
copybara-service
bot
force-pushed
the
test_770243667
branch
from
ca7c802 to
ba27c15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor how inline string fields are tracked for donation.
Instead of a separate HasBits object with one bit per field we track donation in one arbitrary bit in the capacity.
When the string IsLong that bit in the capacity determines if it is donated.
We also remove all the plumbing for these donation bits, on demand arena destructor, etc.