Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added historical calibration database to the plugin and safeguard #83

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jrlomas
Copy link

@jrlomas jrlomas commented Mar 11, 2023

This plugin adds support for an embedded sqlite3 database that stores historical calibration offsets. It is used to determine if the z offset has varied over 3 standard deviations over the past 10 runs, stopping the print and avoiding destroying one's buildplate. If changing nozzles, the pull request implements a new command RESET_HISTORICAL_OFFSET, as to ignore the historical offset and wait for another 10 runs to start to implement the safeguard.

@TitusLabs
Copy link
Member

This is a really interesting approach. What is your experience with it?

However, I am not sure if the approach is sufficient since the offset is already subject to a variance.

And wouldn't it be easier to choose an appropriate z endstop position so that this position plus the configured max. deviation results exactly above the plate? 🤔

@Surion79
Copy link

Surion79 commented Jun 26, 2023

wouldn't it be less complicated and heat generating by doing it like the ercf statistics in a save_variables txt file, since you only want to record the last 10 occurences? doing sql for that purpose is IMHO overkill and maybe an issue for the slower SBCs used as replacement for a pi.

@TitusLabs
Copy link
Member

Yes, I think that would be enough.

However, I don't see any real gain. You can limit the deviations in both directions by now (offset_margins). Accordingly, this does not even have to be around the zero point (by using min and max). But even that would not be a problem if you adjust the Z-end stop position accordingly. Or could the restriction to a mean value be made much tighter? Or am I missing something else here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants