feat: connector v1.3 review #88

D-Nice · 2019-05-23T17:34:59Z

No description provided.

D-Nice · 2019-05-23T18:28:43Z

Regarding this, in the future, it may make more sense to do any stylistic refactors first, and merge them in, as it pollutes the code review, and can enter a review hypnosis where what I'm thinking are stylistic changes may be real code changes.

oraclizeAPI_0.4.25.sol

D-Nice · 2019-05-23T18:30:28Z

oraclizeAPI_0.4.25.sol

    modifier oraclizeAPI {
        if((address(OAR)==0)||(getCodeSize(address(OAR))==0))
            oraclize_setNetwork(networkID_auto);

        if(address(oraclize) != OAR.getAddress())
            oraclize = OraclizeI(OAR.getAddress());
-
+            oraclizeBytes = OraclizeIBytes(OAR.getAddress());


can save some ops by just doing = address(oraclize) here, no?

Ahh wait yes, because the line before ensures oraclize is set. Good spot!

oraclizeAPI_0.4.25.sol

D-Nice · 2019-05-24T19:40:24Z

ping @gskapka

gskapka · 2019-05-28T12:08:51Z

Agreed re the stylistic changes btw. Didn't mean to accidentally do both in tandem, but I did :/ Will ensure to separate the two concerns in future if both sorts of changes are needed. Have pushed all the fixes to the above comments.

D-Nice

Additional points needing addressing

oraclizeAPI_0.4.25.sol

oraclizeAPI_0.5.sol

oraclizeAPI_0.4.25.sol

D-Nice · 2019-06-10T15:54:02Z

LGTM as of 6a0b495

rest please review as well

gskapka

Of your commits, I couldn't approve of the specifier order consistency more! Wohoo!

So yeah, LGTM too.

Have given @riccardopersiani an in-person overview of the changes because if you look at the diffs for the whole branch, they don't even load due to their size! It's given him a fighting chance at a review though & he's on it.

riccardopersiani

Review still need to be finished

oraclizeAPI_0.4.25.sol

oraclizeAPI_0.5.sol

oraclizeAPI_0.4.25.sol

oraclizeAPI_0.5.sol

gskapka · 2019-06-11T14:39:21Z

Changes per @riccardopersiani review pushed & include:

✔️ All 24 uint related things in 0.5API now solved with a better regex of uint\(256\)\@!\(8\)\@!\(160\)\@! in the find & replace.

✔️ address _address param in getPrice overloads now elucidated via renaming to address _contractToQuery.

All comments made re stylistic changes pertaining to 0.4.25 were ignored since the file itself should have been ignored in that regard during review.

oraclizeAPI_0.5.sol

riccardopersiani

LGTM

D-Nice · 2019-07-02T21:50:13Z

In need of rebase (draft #94)

TODOs post-rebase

update copyright in rebased oraclize api
update provableAPI with changes of this PR in single commit
ensure natspec fix ends up included post-merge

...which also makes the visibility specifiers & fxn modifiers easier to see.

Now users can query prices for their (or others') contracts!

...since it's free w/r/t compile size if functions go unused.

... & also cleans up the natspec comments surrounding the various overload types.

... & also update the natspec comments to make the API easier to navigate.

reverting changes I requested for consistency with 0.5 and previous iterations

D-Nice · 2019-07-03T15:09:19Z

rebased and matches #94

also includes various fixes/consistency unto oraclize apis

D-Nice · 2019-07-03T16:14:43Z

Only commit 35d8933

should need review @riccardopersiani

If there is anything questionable, please mention and request review from @gskapka in addition

riccardopersiani

Added just very small notes.

For the rest LGTM. Good job!

oraclizeAPI_0.4.25.sol

@riccardopersiani

courtesy @riccardopersiani Co-Authored-By: Riccardo Persiani <[email protected]>

D-Nice · 2019-07-05T17:59:55Z

resolved

D-Nice requested a review from riccardopersiani May 23, 2019 17:34

D-Nice assigned gskapka May 23, 2019

D-Nice removed the request for review from riccardopersiani May 23, 2019 17:35

D-Nice commented May 23, 2019

View reviewed changes

D-Nice commented Jun 6, 2019

View reviewed changes

oraclizeAPI_0.4.25.sol Outdated Show resolved Hide resolved

oraclizeAPI_0.5.sol Outdated Show resolved Hide resolved

oraclizeAPI_0.4.25.sol Outdated Show resolved Hide resolved

gskapka force-pushed the feat/connector-v1.3 branch 2 times, most recently from 59ee890 to 0082e85 Compare June 10, 2019 15:23

D-Nice marked this pull request as ready for review June 10, 2019 15:49

D-Nice requested a review from riccardopersiani June 10, 2019 15:50

D-Nice requested a review from gskapka June 10, 2019 15:54

gskapka previously approved these changes Jun 10, 2019

View reviewed changes

riccardopersiani suggested changes Jun 10, 2019

View reviewed changes

riccardopersiani suggested changes Jun 11, 2019

View reviewed changes

oraclizeAPI_0.5.sol Outdated Show resolved Hide resolved

oraclizeAPI_0.5.sol Outdated Show resolved Hide resolved

D-Nice commented Jun 11, 2019

View reviewed changes

oraclizeAPI_0.5.sol Outdated Show resolved Hide resolved

gskapka requested a review from riccardopersiani June 11, 2019 17:10

riccardopersiani approved these changes Jun 12, 2019

View reviewed changes

gskapka added 8 commits July 3, 2019 10:59

standard fxn formatting

9d134c1

...which also makes the visibility specifiers & fxn modifiers easier to see.

adds getPrice overloads & makes them view

df57796

Now users can query prices for their (or others') contracts!

switch to explicit uint256

157ba01

standardizes fxn formatting

fe0d698

adds getPrice overloads to connector interface

c06a0b9

fix * spacing

0cd9334

fixes linting isues

11df7e2

adds gasPriceBumping feature to 0.5API

d2348b3

gskapka and others added 17 commits July 3, 2019 10:59

adds getERC20Price overloads to 0.5 API

bf66800

adds getERC20Price overloads to 0.4.25 API

d8e9fcd

explain need for two interfaces in API 0.4.25

b8df609

use extant address to save on opcodes when initting bytes interface

a397081

make getPrice overloads view in API 0.4.25

f68f3a5

feat(0.5API): adds entire ERC20 interface

8c64945

...since it's free w/r/t compile size if functions go unused.

feat(0.5API): adds entire ERC20 interface

d2d987b

optimize(0.5API): rm double lookup of connector address via OAR

0845e8a

optimize(0.4API): rm double lookup of connector address via OAR

452365c

feat(0.5API): adds oraclize_token_query overloads

31e3135

... & also cleans up the natspec comments surrounding the various overload types.

feat(0.4API): adds oraclize_token_query overloads

16d11cf

... & also update the natspec comments to make the API easier to navigate.

fix(0.5API): fixes last remaining compiler warning re pure fxn

fbda2a0

fix(0.4API): revert getPrice views

37d76cd

reverting changes I requested for consistency with 0.5 and previous iterations

refactor: improve specifier order consistency

b9d4923

chore(0.5API): use uint256 explicitly where missing

1ff5a10

chore(0.5API): elucidate address in getPrice fxns

22af856

chore(0.4.25API): elucidate address in getPrice fxns

3d358e4

D-Nice force-pushed the feat/connector-v1.3 branch from a8371e4 to 3d358e4 Compare July 3, 2019 15:01

D-Nice mentioned this pull request Jul 3, 2019

Feat/connector v1.3 rebased WIP #94

Closed

D-Nice added 2 commits July 3, 2019 11:18

chore(copyright): update

bd8deb0

feat: update provable api to 1.3

35d8933

also includes various fixes/consistency unto oraclize apis

D-Nice self-assigned this Jul 3, 2019

D-Nice requested a review from riccardopersiani July 3, 2019 16:12

riccardopersiani suggested changes Jul 5, 2019

View reviewed changes

oraclizeAPI_0.4.25.sol Outdated Show resolved Hide resolved

oraclizeAPI_0.4.25.sol Outdated Show resolved Hide resolved

oraclizeAPI_0.4.25.sol Outdated Show resolved Hide resolved

oraclizeAPI_0.4.25.sol Outdated Show resolved Hide resolved

refactor(style): code review suggestions

211b7b0

courtesy @riccardopersiani Co-Authored-By: Riccardo Persiani <[email protected]>

riccardopersiani unassigned D-Nice Sep 12, 2019

gskapka dismissed their stale review via 211b7b0 September 6, 2022 13:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: connector v1.3 review #88

feat: connector v1.3 review #88

D-Nice commented May 23, 2019

D-Nice commented May 23, 2019

D-Nice May 23, 2019

gskapka May 28, 2019

D-Nice commented May 24, 2019

gskapka commented May 28, 2019

D-Nice left a comment

D-Nice commented Jun 10, 2019

gskapka left a comment

riccardopersiani left a comment

gskapka commented Jun 11, 2019 •

edited

Loading

riccardopersiani left a comment

D-Nice commented Jul 2, 2019 •

edited

Loading

D-Nice commented Jul 3, 2019

D-Nice commented Jul 3, 2019

riccardopersiani left a comment

D-Nice commented Jul 5, 2019

feat: connector v1.3 review #88

Are you sure you want to change the base?

feat: connector v1.3 review #88

Conversation

D-Nice commented May 23, 2019

D-Nice commented May 23, 2019

D-Nice May 23, 2019

Choose a reason for hiding this comment

gskapka May 28, 2019

Choose a reason for hiding this comment

D-Nice commented May 24, 2019

gskapka commented May 28, 2019

D-Nice left a comment

Choose a reason for hiding this comment

D-Nice commented Jun 10, 2019

gskapka left a comment

Choose a reason for hiding this comment

riccardopersiani left a comment

Choose a reason for hiding this comment

gskapka commented Jun 11, 2019 • edited Loading

riccardopersiani left a comment

Choose a reason for hiding this comment

D-Nice commented Jul 2, 2019 • edited Loading

D-Nice commented Jul 3, 2019

D-Nice commented Jul 3, 2019

riccardopersiani left a comment

Choose a reason for hiding this comment

D-Nice commented Jul 5, 2019

gskapka commented Jun 11, 2019 •

edited

Loading

D-Nice commented Jul 2, 2019 •

edited

Loading