-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore(models): add pydantic validators for CheckMetadata
#8583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
HugoPBrito
wants to merge
21
commits into
master
Choose a base branch
from
PRWLR-7706-add-pydantic-validators-to-check-metadata-model-per-rfc-specification
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
chore(models): add pydantic validators for CheckMetadata
#8583
HugoPBrito
wants to merge
21
commits into
master
from
PRWLR-7706-add-pydantic-validators-to-check-metadata-model-per-rfc-specification
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion.Recommendation.Url
…o PRWLR-7706-add-pydantic-validators-to-check-metadata-model-per-rfc-specification
✅ All necessary |
…o review-metadata-aws-neptune
…ic-validators-to-check-metadata-model-per-rfc-specification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
integration/security-hub
Issues/PRs related with the AWS Security Hub integration
output/asff
Issues/PRs related with the ASFF output format
output/csv
Issues/PRs related with the CSV output format
output/ocsf
Issues/PRs related with the OCSF output format
provider/aws
Issues/PRs related with the AWS provider
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We have defined new metadata format that implies changes in the fields, that now must be validated.
Description
This PR enhances the
CheckMetadata
Pydantic model with custom validators to enforce the new format constraints defined.Steps to review
Please add a detailed description of how to review this PR.
Checklist
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.