-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore(aws): enhance metadata for acm
service
#8716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Please add an entry to the corresponding |
acm
service
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8716 +/- ##
===========================================
+ Coverage 75.47% 88.01% +12.54%
===========================================
Files 72 901 +829
Lines 4962 28320 +23358
===========================================
+ Hits 3745 24926 +21181
- Misses 1217 3394 +2177
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
acm
serviceacm
service
"https://cloudviz.io/blog/15-aws-config-rules-every-aws-account-should-have", | ||
"https://aws.plainenglish.io/streamline-ssl-tls-certificates-with-aws-certificate-manager-acm-7e792e2c575e", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"https://cloudviz.io/blog/15-aws-config-rules-every-aws-account-should-have", | |
"https://aws.plainenglish.io/streamline-ssl-tls-certificates-with-aws-certificate-manager-acm-7e792e2c575e", |
"AdditionalURLs": [ | ||
"https://cloudviz.io/blog/15-aws-config-rules-every-aws-account-should-have", | ||
"https://aws.plainenglish.io/streamline-ssl-tls-certificates-with-aws-certificate-manager-acm-7e792e2c575e", | ||
"https://www.clouddefense.ai/compliance-rules/cisa-cyber-essentials/data/acm-certificate-expires-30-days", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"https://www.clouddefense.ai/compliance-rules/cisa-cyber-essentials/data/acm-certificate-expires-30-days", | |
"https://www.trendmicro.com/cloudoneconformity/knowledge-base/aws/ACM/certificate-expires-in-45-days.html", |
"https://cloudviz.io/blog/15-aws-config-rules-every-aws-account-should-have", | ||
"https://aws.plainenglish.io/streamline-ssl-tls-certificates-with-aws-certificate-manager-acm-7e792e2c575e", | ||
"https://www.clouddefense.ai/compliance-rules/cisa-cyber-essentials/data/acm-certificate-expires-30-days", | ||
"https://cloudcustodian.io/docs/aws/resources/acm-certificate.html", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"https://cloudcustodian.io/docs/aws/resources/acm-certificate.html", |
"https://aws.plainenglish.io/streamline-ssl-tls-certificates-with-aws-certificate-manager-acm-7e792e2c575e", | ||
"https://www.clouddefense.ai/compliance-rules/cisa-cyber-essentials/data/acm-certificate-expires-30-days", | ||
"https://cloudcustodian.io/docs/aws/resources/acm-certificate.html", | ||
"https://docs.gruntwork.io/reference/modules/terraform-aws-security/aws-config-rules/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"https://docs.gruntwork.io/reference/modules/terraform-aws-security/aws-config-rules/", |
"https://www.clouddefense.ai/compliance-rules/cisa-cyber-essentials/data/acm-certificate-expires-30-days", | ||
"https://cloudcustodian.io/docs/aws/resources/acm-certificate.html", | ||
"https://docs.gruntwork.io/reference/modules/terraform-aws-security/aws-config-rules/", | ||
"https://asecure.cloud/a/acm-certificate-expiration-check/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"https://asecure.cloud/a/acm-certificate-expiration-check/", |
"https://stackoverflow.com/questions/67606544/how-to-solve-aws-cloudfront-ssl-certificate-doesnt-exist", | ||
"https://repost.aws/questions/QUhtmyY4d5SK6dvKUen8A7xg/aws-acm-algorithm-and-encryption", | ||
"https://sdk.amazonaws.com/kotlin/api/latest/acm/aws.sdk.kotlin.services.acm.model/-request-certificate-request/-builder/key-algorithm.html", | ||
"https://docs.aws.amazon.com/acm/latest/userguide/acm-certificate.html", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"https://docs.aws.amazon.com/acm/latest/userguide/acm-certificate.html", | |
"https://docs.aws.amazon.com/acm/latest/userguide/data-protection.html" |
"https://repost.aws/questions/QUhtmyY4d5SK6dvKUen8A7xg/aws-acm-algorithm-and-encryption", | ||
"https://sdk.amazonaws.com/kotlin/api/latest/acm/aws.sdk.kotlin.services.acm.model/-request-certificate-request/-builder/key-algorithm.html", | ||
"https://docs.aws.amazon.com/acm/latest/userguide/acm-certificate.html", | ||
"https://docs.aws.amazon.com/securityhub/latest/userguide/acm-controls.html#acm-2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"https://docs.aws.amazon.com/securityhub/latest/userguide/acm-controls.html#acm-2" |
"NativeIaC": "", | ||
"Other": "", | ||
"Terraform": "" | ||
"NativeIaC": "```yaml\n# CloudFormation: ACM certificate with secure key algorithm\nResources:\n <example_resource_name>:\n Type: AWS::CertificateManager::Certificate\n Properties:\n DomainName: <example_domain>\n KeyAlgorithm: EC_prime256v1 # CRITICAL: ensures a secure key algorithm (ECDSA P-256) to pass the check\n```", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"NativeIaC": "```yaml\n# CloudFormation: ACM certificate with secure key algorithm\nResources:\n <example_resource_name>:\n Type: AWS::CertificateManager::Certificate\n Properties:\n DomainName: <example_domain>\n KeyAlgorithm: EC_prime256v1 # CRITICAL: ensures a secure key algorithm (ECDSA P-256) to pass the check\n```", | |
"NativeIaC": "```yaml\n# CloudFormation: ACM certificate with secure key algorithm\nResources:\n <example_resource_name>:\n Type: AWS::CertificateManager::Certificate\n Properties:\n DomainName: <example_domain>\n KeyAlgorithm: EC_prime256v1 # CRITICAL: ensures a secure key algorithm (RSA-2048+ or ECDSA P-256+)\n```", |
"Terraform": "" | ||
"NativeIaC": "```yaml\n# CloudFormation: ACM certificate with secure key algorithm\nResources:\n <example_resource_name>:\n Type: AWS::CertificateManager::Certificate\n Properties:\n DomainName: <example_domain>\n KeyAlgorithm: EC_prime256v1 # CRITICAL: ensures a secure key algorithm (ECDSA P-256) to pass the check\n```", | ||
"Other": "1. In the AWS Console, go to Certificate Manager (ACM)\n2. Click Request a certificate and enter <example_domain>\n3. Under Key algorithm, select ECDSA P-256 (or RSA 2048)\n4. Complete validation (DNS is recommended)\n5. In the service using the certificate (e.g., ALB/CloudFront/API Gateway), replace the old certificate with the new one\n6. Delete the insecure certificate (e.g., RSA-1024 or P-192) once no longer in use\n7. For CloudFront, request the certificate in us-east-1", | ||
"Terraform": "```hcl\n# Terraform: ACM certificate with secure key algorithm\nresource \"aws_acm_certificate\" \"<example_resource_name>\" {\n domain_name = \"<example_domain>\"\n key_algorithm = \"EC_prime256v1\" # CRITICAL: ensures a secure key algorithm (ECDSA P-256) to pass the check\n}\n```" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Terraform": "```hcl\n# Terraform: ACM certificate with secure key algorithm\nresource \"aws_acm_certificate\" \"<example_resource_name>\" {\n domain_name = \"<example_domain>\"\n key_algorithm = \"EC_prime256v1\" # CRITICAL: ensures a secure key algorithm (ECDSA P-256) to pass the check\n}\n```" | |
"Terraform": "```hcl\n# Terraform: ACM certificate with secure key algorithm\nresource \"aws_acm_certificate\" \"<example_resource_name>\" {\n domain_name = \"<example_domain>\"\n key_algorithm = \"EC_prime256v1\" # CRITICAL: ensures a secure key algorithm (RSA-2048+ or ECDSA P-256+)\n}\n```" |
"Other": "", | ||
"Terraform": "" | ||
"NativeIaC": "```yaml\n# CloudFormation: ACM certificate with secure key algorithm\nResources:\n <example_resource_name>:\n Type: AWS::CertificateManager::Certificate\n Properties:\n DomainName: <example_domain>\n KeyAlgorithm: EC_prime256v1 # CRITICAL: ensures a secure key algorithm (ECDSA P-256) to pass the check\n```", | ||
"Other": "1. In the AWS Console, go to Certificate Manager (ACM)\n2. Click Request a certificate and enter <example_domain>\n3. Under Key algorithm, select ECDSA P-256 (or RSA 2048)\n4. Complete validation (DNS is recommended)\n5. In the service using the certificate (e.g., ALB/CloudFront/API Gateway), replace the old certificate with the new one\n6. Delete the insecure certificate (e.g., RSA-1024 or P-192) once no longer in use\n7. For CloudFront, request the certificate in us-east-1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Other": "1. In the AWS Console, go to Certificate Manager (ACM)\n2. Click Request a certificate and enter <example_domain>\n3. Under Key algorithm, select ECDSA P-256 (or RSA 2048)\n4. Complete validation (DNS is recommended)\n5. In the service using the certificate (e.g., ALB/CloudFront/API Gateway), replace the old certificate with the new one\n6. Delete the insecure certificate (e.g., RSA-1024 or P-192) once no longer in use\n7. For CloudFront, request the certificate in us-east-1", | |
"Other": "1. In the AWS Console, go to Certificate Manager (ACM)\n2. Click Request a certificate and enter <example_domain>\n3. Under Key algorithm, select ECDSA P-256 (or RSA 2048)\n4. Complete validation (DNS is recommended)\n5. In the service using the certificate (e.g., ALB/CloudFront/API Gateway), replace the old certificate with the new one\n6. Delete the insecure certificate (e.g., RSA-1024 or P-192) once no longer in use.", |
Context
Updating aws acm service metadata to conform with the new standardized metadata format used across Prowler checks, defined in #8411.
Description
This PR updates all metadata files for aws acm checks to adapt to the new metadata format. The changes ensure consistency with the metadata structure being adopted across all Prowler services. The modified checks are:
acm_certificates_expiration_check
acm_certificates_transparency_logs_enabled
acm_certificates_with_secure_key_algorithms
Checklist
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.