-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(gcp): add check to detect Compute Engine configuration changes #9698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gcp): add check to detect Compute Engine configuration changes #9698
Conversation
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
|
✅ All necessary |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9698 +/- ##
==========================================
+ Coverage 92.82% 93.00% +0.18%
==========================================
Files 130 133 +3
Lines 3178 3275 +97
==========================================
+ Hits 2950 3046 +96
- Misses 228 229 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
🔒 Container Security ScanImage: 📊 Vulnerability Summary
3 package(s) affected
|
HugoPBrito
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more a logging check, despite checking compute service. Please see other logging checks and adapt it to follow the same scheme.
Context
New security check for GCP to detect recent Compute Engine configuration changes by inspecting Cloud Audit Logs. This check helps operators identify unexpected or unauthorized modifications to Compute Engine resources such as instances, disks, and networks.
Description
This PR adds a new GCP check that inspects Cloud Audit Logs (Admin Activity) for recent Compute Engine configuration changes within a configurable lookback window. The check reports:
Steps to review
AuditLogEntrymodel inlogging_service.py_get_compute_audit_entries()method:logging_compute_audit_log_changes_detected.pymetadata.jsonfor accuracygcp_fixtures.pyChecklist
UI
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.