Skip to content

Conversation

@alejandrobailo
Copy link
Contributor

@alejandrobailo alejandrobailo commented Dec 30, 2025

demo.mov

Context

Redesign of the Findings table UI with new design system components, improved filtering UX, and enhanced table interactions.

Description

  • New table design: Rounded rows, redesigned pagination with lucide icons, updated severity/status badges with new color system
  • New cell components: NotificationIndicator (new/changed/muted), ProviderIconCell, ImpactedResourcesCell for cleaner column rendering
  • Redesigned filters: ProviderTypeSelector and AccountsSelector replace old provider filter, collapsible "More Filters" section, new shadcn Calendar date picker
  • Search functionality: New expandable search input in table toolbar with debounce and loading state
  • shadcn components: New Calendar component with react-day-picker, updated Checkbox (24x24px) and Select (iconSize prop)

Steps to review

  1. UI Testing: Navigate to /findings and verify:
    • Table rows have rounded corners and proper hover states
    • Pagination controls work correctly with new icons
    • Severity/Status badges display with new design
  2. Filters UX: Test the new filter layout:
    • ProviderTypeSelector and AccountsSelector dropdowns work
    • "More Filters" toggle expands/collapses additional filters
    • Date picker opens Calendar popover correctly
    • "Clear Filters (X)" shows count and clears all
  3. Search: Verify expandable search in table toolbar:
    • Expands on hover/click, collapses when empty and unfocused
    • Debounce works (300ms delay before URL update)
    • Loading spinner appears during search
  4. Cell components: Check new column rendering:
    • Pink dot for new/changed findings, muted icon with tooltip
    • Provider icons display correctly
    • Finding title is clickable and opens detail sheet
  5. Type safety: Run pnpm run typecheck - should pass
  6. Responsiveness: Test on different screen sizes

Checklist

UI

  • All issue/task requirements work as expected on the UI
  • Screenshots/Video of the functionality flow (if applicable) - Mobile (X < 640px)
  • Screenshots/Video of the functionality flow (if applicable) - Table (640px > X < 1024px)
  • Screenshots/Video of the functionality flow (if applicable) - Desktop (X > 1024px)
  • Ensure new entries are added to CHANGELOG.md, if applicable.

API

  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alejandrobailo alejandrobailo self-assigned this Dec 30, 2025
@alejandrobailo alejandrobailo requested a review from a team as a code owner December 30, 2025 08:59
@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

✅ All necessary CHANGELOG.md files have been updated.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

🔒 Container Security Scan

Image: prowler-ui:4fb36e9
Last scan: 2026-01-12 14:10:39 UTC

✅ No Vulnerabilities Detected

The container image passed all security checks. No known CVEs were found.

📋 Resources:

Copy link
Contributor

@Alan-TheGentleman Alan-TheGentleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

solid work! Clean component architecture, proper type safety with as const, and the ExpandableSection using CSS grid for animations is the right approach. 👍

🟡 Request: Add TODO with ticket reference for commented code

In ui/components/findings/table/column-findings.tsx, the commented out ImpactedResourcesCell code (lines 21 and 265-277) should have a ticket reference so it doesn't become mystery code later.

Please update to:

// TODO: PROWLER-379 - Enable ImpactedResourcesCell when backend supports grouped findings
// import { ImpactedResourcesCell } from "./impacted-resources-cell";

And same for the column definition block.


🟢 Minor: Dead export

ImpactedResourcesCell is exported in index.ts but never used. Not blocking, just noting it adds to bundle size. Can clean up now or leave for when the feature is ready.

Copy link
Contributor

@Alan-TheGentleman Alan-TheGentleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the previous two requests 👍

@alejandrobailo alejandrobailo requested a review from a team as a code owner January 12, 2026 10:27
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2026

🔒 Container Security Scan

Image: prowler-api:4fb36e9
Last scan: 2026-01-12 14:06:28 UTC

📊 Vulnerability Summary

Severity Count
🔴 Critical 11
Total 11

10 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

  • Review the detailed scan results
  • Update affected packages to patched versions
  • Consider using a different base image if updates are unavailable

📋 Resources:

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.51%. Comparing base (144d59d) to head (af68429).
⚠️ Report is 61 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9699      +/-   ##
==========================================
- Coverage   92.70%   92.51%   -0.19%     
==========================================
  Files         129      163      +34     
  Lines        3153    23285   +20132     
==========================================
+ Hits         2923    21543   +18620     
- Misses        230     1742    +1512     
Flag Coverage Δ
api 92.51% <100.00%> (?)
prowler-py3.10-gcp ?
prowler-py3.11-gcp ?
prowler-py3.12-gcp ?
prowler-py3.9-gcp ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler ∅ <ø> (∅)
api 92.51% <100.00%> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alejandrobailo alejandrobailo merged commit d38be93 into master Jan 12, 2026
37 of 38 checks passed
@alejandrobailo alejandrobailo deleted the feat/PROWLER-379-new-table branch January 12, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants