Skip to content

Conversation

@mchennai
Copy link
Contributor

@mchennai mchennai commented Jan 6, 2026

Description

Adds test coverage for an S3 access logging edge case where the bucket logging status exists but does not include LoggingEnabled.

Testing

  • pytest -q tests/providers/aws/services/s3/s3_bucket_server_access_logging_enabled/s3_bucket_server_access_logging_enabled_test.py

@mchennai mchennai requested review from a team as code owners January 6, 2026 13:28
@github-actions github-actions bot added provider/aws Issues/PRs related with the AWS provider community Opened by the Community labels Jan 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 12.97%. Comparing base (4169611) to head (1d37738).
⚠️ Report is 47 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9725   +/-   ##
=======================================
  Coverage   12.97%   12.97%           
=======================================
  Files         830      830           
  Lines       23435    23435           
=======================================
  Hits         3041     3041           
  Misses      20394    20394           
Flag Coverage Δ
prowler-py3.10-aws 12.97% <ø> (ø)
prowler-py3.11-aws 12.97% <ø> (ø)
prowler-py3.12-aws 12.97% <ø> (ø)
prowler-py3.9-aws 12.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 12.97% <ø> (ø)
api ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jfagoagas jfagoagas changed the title Add edge case test for s3_bucket_server_access_logging_enabled test: Add edge case test for s3_bucket_server_access_logging_enabled Jan 9, 2026
@mchennai
Copy link
Contributor Author

Hi maintainers — this PR adds test coverage only (no production code changes). It validates mixed PASS/FAIL results across multiple S3 buckets for s3_bucket_server_access_logging_enabled. Thanks for reviewing.

@jfagoagas
Copy link
Member

Hi maintainers — this PR adds test coverage only (no production code changes). It validates mixed PASS/FAIL results across multiple S3 buckets for s3_bucket_server_access_logging_enabled. Thanks for reviewing.

That's great! I've fixed some linting issues. I'll merge once tests pass.

@jfagoagas jfagoagas merged commit 05466cf into prowler-cloud:master Jan 12, 2026
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Opened by the Community provider/aws Issues/PRs related with the AWS provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants