-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: new finding detail view #9727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new finding detail view #9727
Conversation
| onOpenChange={onOpenChange} | ||
| > | ||
| <DrawerTrigger asChild>{trigger}</DrawerTrigger> | ||
| <DrawerContent className="minimal-scrollbar 3xl:w-1/3 h-full w-full overflow-x-hidden overflow-y-auto p-6 md:w-1/2 md:max-w-none"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 3xl breakpoint is not standard Tailwind (only goes up to 2xl). Verify it's configured in tailwind.config.js, otherwise this won't work.
| import { Tooltip } from "@heroui/tooltip"; | ||
| import { ExternalLink, Link } from "lucide-react"; | ||
| import { ExternalLink, Link, X } from "lucide-react"; | ||
| import type { ReactNode } from "react"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Line 87-90 uses window.location directly which can cause hydration mismatch in Next.js. Consider using usePathname() and useSearchParams() from Next.js:
const pathname = usePathname();
const searchParams = useSearchParams();
// Build URL using Next.js hooks instead of window.location
const params = new URLSearchParams(searchParams);
params.set('id', findingDetails.id);
const url = `${pathname}?${params.toString()}`;This is pre-existing code, but worth addressing.
|
Thank youuu! One concern:
Minor/nits
|
Context
Redesign the findings table with improved UX including new cell components, tabbed finding details in a drawer, enhanced filters with date picker, and updated design system components.
Screen.Recording.2026-01-07.at.11.02.32.mov
Description
Steps to review
pnpm run typecheckChecklist
UI
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.