Skip to content

Conversation

@pedrooot
Copy link
Member

@pedrooot pedrooot commented Jan 7, 2026

Description

This pull request adds comprehensive end-to-end (E2E) test support for Alibaba Cloud provider integration in the UI test suite. It introduces new environment variables, updates Playwright page objects, and implements E2E tests for adding Alibaba Cloud providers with both static credentials and RAM Role credentials. Additionally, it documents the use of a specific package manager version for the UI.

Alibaba Cloud Provider E2E Test Integration

  • Adds new environment variables for Alibaba Cloud credentials to the GitHub Actions workflow to support E2E testing.
  • Implements Alibaba Cloud provider data structures, credential types, and Playwright page object locators and methods in providers-page.ts to enable UI automation for Alibaba Cloud provider flows. [1] [2] [3] [4] [5] [6] [7] [8]

E2E Test Implementation

  • Adds two new E2E test cases in providers.spec.ts for adding an Alibaba Cloud provider using static credentials and RAM Role credentials, including verification of scan scheduling. [1] [2]

Tooling

  • Documents the use of pnpm as the package manager and pins its version in package.json for reproducible builds.

Steps to review

Please add a detailed description of how to review this PR.

Checklist

UI

  • All issue/task requirements work as expected on the UI
  • Screenshots/Video of the functionality flow (if applicable) - Mobile (X < 640px)
  • Screenshots/Video of the functionality flow (if applicable) - Table (640px > X < 1024px)
  • Screenshots/Video of the functionality flow (if applicable) - Desktop (X > 1024px)
  • Ensure new entries are added to CHANGELOG.md, if applicable.

API

  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested review from a team as code owners January 7, 2026 15:57
@github-actions github-actions bot added github_actions Pull requests that update GitHub Actions code component/ui labels Jan 7, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

⚠️ Changes detected in the following folders without a corresponding update to the CHANGELOG.md:

  • ui

Please add an entry to the corresponding CHANGELOG.md file to maintain a clear history of changes.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

🔒 Container Security Scan

Image: prowler-ui:6654b2d
Last scan: 2026-01-13 14:58:59 UTC

✅ No Vulnerabilities Detected

The container image passed all security checks. No known CVEs were found.

📋 Resources:

@StylusFrost
Copy link
Contributor

Hi! Good Job!
Please check providers.md file and complete this with new e2e tests

@StylusFrost StylusFrost added the no-changelog Skip including change in changelog/release notes label Jan 8, 2026
@pedrooot
Copy link
Member Author

Done! @StylusFrost thanks for the revision ✅

@StylusFrost StylusFrost self-requested a review January 13, 2026 12:25
StylusFrost
StylusFrost previously approved these changes Jan 13, 2026
Copy link
Contributor

@StylusFrost StylusFrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Thanks @pedrooot !

@StylusFrost StylusFrost requested a review from a team January 13, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/ui github_actions Pull requests that update GitHub Actions code no-changelog Skip including change in changelog/release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants