Skip to content

Conversation

@andoniaf
Copy link
Member

Summary

Add new Agent Skill for reviewing PRs that add or modify compliance frameworks. This skill provides a standardized review process that can be followed by team members manually or used by AI agents.

What's Included

  • SKILL.md: Review checklist, decision tree, and patterns for reviewing compliance framework PRs
  • validate_compliance.py: Validation script that checks:
    • JSON syntax validity
    • All referenced checks exist in the codebase
    • No duplicate requirement IDs
    • Assessment status consistency
  • review-checklist.md: References to related docs and PR review template

Why This Skill?

This skill complements the existing prowler-compliance skill (which creates frameworks) by focusing on the review/validation process. It standardizes how we review compliance framework PRs and ensures consistency.

Usage

Manual review:

# Run validation script
python3 skills/prowler-compliance-review/assets/validate_compliance.py \
  prowler/compliance/azure/cis_5.0_azure.json

AI-assisted review:
The skill can be loaded by AI agents when reviewing compliance PRs, providing them with the checklist and decision tree to follow.

Test Results

Tested against existing frameworks:

  • CIS 4.0 Azure: 139 requirements, 91 checks - PASS
  • CIS 3.0 AWS: 62 requirements, 67 checks - PASS

Checklist

  • Review checklist and decision tree
  • Validation script tested
  • Skill registered in AGENTS.md
  • Follows agentskills.io specification pattern

Add new Agent Skill for reviewing PRs that add or modify compliance
frameworks. This skill provides:

- Review checklist with pass/fail criteria
- Validation script to verify check existence and JSON validity
- Decision tree for review recommendations
- Dashboard file pattern reference

The skill complements prowler-compliance (creates frameworks) by
focusing on the review/validation process.
@andoniaf andoniaf requested a review from a team as a code owner January 13, 2026 08:23
@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2026

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2026

✅ All necessary CHANGELOG.md files have been updated.

- Rename "Validation Commands" to "Commands"
- Replace "Agent Integration" with "Testing the Compliance Framework"
pedrooot
pedrooot previously approved these changes Jan 13, 2026
Copy link
Member

@pedrooot pedrooot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We needed this!! 🔝 thanks a lot mate

@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2026

🔒 Container Security Scan

Image: prowler:c591c1c
Last scan: 2026-01-13 08:41:11 UTC

📊 Vulnerability Summary

Severity Count
🔴 Critical 3
Total 3

3 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

  • Review the detailed scan results
  • Update affected packages to patched versions
  • Consider using a different base image if updates are unavailable

📋 Resources:

@andoniaf andoniaf changed the base branch from master to feat/ai-skills-sync-agents-md January 13, 2026 09:23
@andoniaf andoniaf requested review from a team as code owners January 13, 2026 09:23
@andoniaf andoniaf changed the base branch from feat/ai-skills-sync-agents-md to master January 13, 2026 09:23
@andoniaf andoniaf dismissed pedrooot’s stale review January 13, 2026 09:23

The base branch was changed.

@andoniaf
Copy link
Member Author

Manually merged into #9751

@andoniaf andoniaf closed this Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants