Read info abouy abrasive material and high-flow nozzle #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarkafa
reviewed
Sep 3, 2024
pybgcode/pybgcode/__init__.py
Outdated
|
|
||
|
|
||
| def filter_connect_metadata(output: dict) -> dict: | ||
| all_metadata = {**output['print'], **output['printer']} | ||
| all_metadata = {**output['print'], **output['printer'], **output['slicer']} |
There was a problem hiding this comment.
neříkali, že nám ty trysky přijdají do těch printer metadat?
There was a problem hiding this comment.
Jasně že jo, jsem pitiomej, díky!
fiksupojka
force-pushed
the
new-metadata-read
branch
from
2f5712c
to
709f415
Compare
fiksupojka
force-pushed
the
new-metadata-read
branch
from
709f415
to
9e174a1
Compare
ondratu
approved these changes
Sep 3, 2024
sarkafa
reviewed
Sep 3, 2024
| @@ -144,7 +144,8 @@ def read_metadata(gcodefile: FILEWrapper, type: str = 'printer'): | |||
| "support_material", "ironing", "quiet_percent_present", | |||
| "quiet_left_present", "quiet_change_in_present", "normal_percent_present", | |||
| "normal_left_present", "normal_change_in_present", "layer_info_present", | |||
| "max_layer_z", "objects_info", "extruder_colour"] | |||
| "max_layer_z", "objects_info", "extruder_colour", "filament_abrasive", | |||
There was a problem hiding this comment.
nepřidáš to ještě do testů?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding two more values for Connect metadata, both of them are in slicer metadata, so slicer metadata reading had to be added to file scan when reading data for Connect