Update geth to 1.12.1 (#12718)

* Update geth to 1.12.1 * Fix //cmd/validator/flags:go_default_test * fix //beacon-chain/node:go_default_test --------- Co-authored-by: Nishant Das <[email protected]>
prysmaticlabs · Aug 11, 2023 · aeb7a45 · aeb7a45
1 parent e952fd8
commit aeb7a45
Show file tree

Hide file tree

Showing 7 changed files with 247 additions and 111 deletions.
diff --git a/beacon-chain/node/config_test.go b/beacon-chain/node/config_test.go
@@ -158,8 +158,7 @@ func TestConfigureNetwork_ConfigFile(t *testing.T) {
 			return cmd.LoadFlagsFromConfig(cliCtx, comFlags)
 		},
 		Action: func(cliCtx *cli.Context) error {
-			//TODO: https://github.com/urfave/cli/issues/1197 right now does not set flag
-			require.Equal(t, false, cliCtx.IsSet(cmd.BootstrapNode.Name))
+			require.Equal(t, true, cliCtx.IsSet(cmd.BootstrapNode.Name))
 
 			require.Equal(t, strings.Join([]string{"node1", "node2"}, ","),
 				strings.Join(cliCtx.StringSlice(cmd.BootstrapNode.Name), ","))

diff --git a/cmd/validator/flags/flags_test.go b/cmd/validator/flags/flags_test.go
@@ -40,8 +40,7 @@ func TestLoadFlagsFromConfig_PreProcessing_Web3signer(t *testing.T) {
 			return cmd.LoadFlagsFromConfig(cliCtx, comFlags)
 		},
 		Action: func(cliCtx *cli.Context) error {
-			//TODO: https://github.com/urfave/cli/issues/1197 right now does not set flag
-			require.Equal(t, false, cliCtx.IsSet(Web3SignerPublicValidatorKeysFlag.Name))
+			require.Equal(t, true, cliCtx.IsSet(Web3SignerPublicValidatorKeysFlag.Name))
 
 			require.Equal(t, strings.Join([]string{pubkey1, pubkey2}, ","),
 				strings.Join(cliCtx.StringSlice(Web3SignerPublicValidatorKeysFlag.Name), ","))