Electra: EIP-7251 Update process_voluntary_exit
#14176
Conversation
| @@ -186,6 +190,18 @@ func verifyExitConditions(validator state.ReadOnlyValidator, currentSlot primiti | |||
| params.BeaconConfig().ShardCommitteePeriod, | |||
| validator.ActivationEpoch()+params.BeaconConfig().ShardCommitteePeriod, | |||
| ) | |||
| } | |||
|
|
|||
| if st.Version() >= version.Electra { | |||
There was a problem hiding this comment.
do we want to break this out from the core blocks into electra?
There was a problem hiding this comment.
Eventually. Breaking this out would involve breaking the other forks out and it would be a large change. Currently trying to get to devnet-1 while taking note of this. I'll take a note of this, thanks
prestonvanloon
force-pushed
the
electra-process_voluntary_exit
branch
from
e6d3240
to
ae696b6
Compare
prestonvanloon
force-pushed
the
electra-process_voluntary_exit
branch
from
ae696b6
to
f5e6376
Compare
beacon-chain/core/blocks/exit.go
Outdated
| // # Verify signature | ||
| // domain = get_domain(state, DOMAIN_VOLUNTARY_EXIT, voluntary_exit.epoch) | ||
| // signing_root = compute_signing_root(voluntary_exit, domain) | ||
| // assert bls.Verify(validator.pubkey, signing_root, signed_voluntary_exit.signature) | ||
| // # Initiate exit | ||
| // initiate_validator_exit(state, voluntary_exit.validator_index) | ||
| func verifyExitConditions(validator state.ReadOnlyValidator, currentSlot primitives.Slot, exit *ethpb.VoluntaryExit) error { | ||
| func verifyExitConditions(st state.ReadOnlyBeaconState, validator state.ReadOnlyValidator, currentSlot primitives.Slot, exit *ethpb.VoluntaryExit) error { | ||
| currentEpoch := slots.ToEpoch(currentSlot) |
There was a problem hiding this comment.
I am worried about the new state not being compatible with currentSlot here. Either the state should have state.Slot() == currentSlot in which case you can just not pass this old parameter, or you need to ensure compatibility. One may be acting on an exit for a slot with data from an old state.
There was a problem hiding this comment.
OK that is fair, I will remove the state parameter and require the fork parameter.
There was a problem hiding this comment.
Oh, actually, we must have the state. So the correct solution is to remove currentSlot and reference state.Slot() as you mentioned
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Updates process_voluntary_exit to the spec changes at v1.5.0-alpha.3
Which issues(s) does this PR fix?
Other notes for review
Introduced in ethereum/consensus-specs#3668